User tests: Successful: Unsuccessful:
If you have a question then it must end in a question mark (?)
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Language & Strings |
Labels |
Added:
?
?
|
@brianteeman you missed the question mark(?) in line 38 i.e(c59de36#diff-5d48ad66aabb95680a8bbb95199245feR38)
@shivamdiehard yes that was on purpose as that change needs to be made across all components and I wanted to do those all in another PR
I have tested this item
@brianteeman ok
oops @shivamdiehard I was wrong - that was only in this component so I have added the ? to it here
I have tested this item
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
Labels |
RTC
i have remarked recently this tendancy to use a question instead of a normal phrase of type: Choose or not to... etc. tbh, i am not a fan of this way of writing a tip.
off topic for this pr
http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
Virus-free.
www.avg.com
http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
On 17 March 2017 at 14:23, infograf768 notifications@github.com wrote:
i have remarked recently this tendancy to use a question instead of a
normal phrase of type: Choose or not to... etc. tbh, i am not a fan of this
way of writing a tip.—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#14676 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8W9D1te2laW_vE31Y_xMBR3IuitYks5rmpdOgaJpZM4Mfm8J
.
--
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-18 12:01:12 |
Closed_By | ⇒ | Bakual | |
Labels |
Added:
?
|
I have tested this item✅ successfully on 950040a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14676.