[#14665] - Tags
- Fixed in Code Base
- 28 Mar 2017
- Medium
- Build: staging
- # 14665
- Diff
- brianteeman:tags
User tests: Successful: Unsuccessful:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | com_tags Front End |
| Labels |
Added:
?
|
||
@brianteeman i have just fixed a space that was to much in that file with 4f9fba8 ;)
@tonypartridge can you test this one if you get a moment - I tested your tags PR ;)
Hey Brian,
I have already tested this because I wrote a very similar fix with @wilsonge closed in favour of:
https://github.com/joomla/joomla-cms/pull/13906/files
However, yours resolves two issues so therefore trumps #13906 IMHO as it is more in-depth.
I'll just double test now. then @wilsonge can merge this and close #13906 ?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14665.
Thanks @tonypartridge
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-28 12:18:36 |
| Closed_By | ⇒ | wilsonge |
Merged with two good tests (ignoring tobias' codestyle fix)
only for the sake of two good tests (because one was before and one was after your codestyle fix) :) your fix was good!
Ah ok. I just was confused ;)
I have tested this item✅ successfully on 482c97f
thanks @brianteeman
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14665.