No Code Attached Yet J4 Issue bug
avatar wilsonge
wilsonge
16 Mar 2017

HTML output here needs to be allowed to be overridden by a template: https://github.com/infograf768/joomla-cms/blob/15a3bb16356d3f62e6a590a996b5bac4d5d3f315/administrator/components/com_associations/helpers/associations.php#L172

Expected result

The HTML is over-rideable with a JLayout

Actual result

It's hardcoded

Additional comments

avatar wilsonge wilsonge - open - 16 Mar 2017
avatar joomla-cms-bot joomla-cms-bot - change - 16 Mar 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 16 Mar 2017
avatar infograf768
infograf768 - comment - 16 Mar 2017

let's first merge #14661 as it is just an improvment on the existing.
then see how it could be done. not sure i know.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14662.

avatar infograf768
infograf768 - comment - 17 Mar 2017

we already use
return JLayoutHelper::render('joomla.content.associations', $items);

as in other places in core for the same type of display.
Do you mean we have to create another type of layout?

avatar Bakual
Bakual - comment - 17 Mar 2017

The problem is that this JLayout isn't an ideal one. You pass allready generated HTML (the link with a tooltip) and it only creates an list from it.
Ideally you would pass it the needed raw data (url, language) and the JLayout creates the link itself from it.
Also the JHtml::_('bootstrap.popover'); should be in that JLayout.

I don't think it is possible to change it now without breaking anything. Moving the JHtml call should be fine but rest will be tricky.

avatar wilsonge
wilsonge - comment - 17 Mar 2017

This is a 3.7 feature. Why can't we do it without breaking things?

avatar Bakual
Bakual - comment - 17 Mar 2017

This is a 3.7 feature. Why can't we do it without breaking things?

The JLayout that is currently used here isn't a new one, it exists since Joomla 3.1 (#1178). You can't break that one.

We could create a new Jlayout for the association manager that isn't used anywhere else (and put it itno the component folder pretty please) or use the existing JLayout as we currently do and refactor the JLayout in future to make it more flexible.

avatar infograf768 infograf768 - change - 17 Mar 2017
Category com_associations
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 3 Apr 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 3 Apr 2017
Category com_associations com_associations Feature Request
avatar franz-wohlkoenig franz-wohlkoenig - change - 3 Apr 2017
Priority Medium Low
Status New Confirmed
avatar franz-wohlkoenig franz-wohlkoenig - change - 8 Nov 2017
Status Confirmed Discussion
avatar brianteeman brianteeman - labeled - 25 Mar 2018
avatar jwaisner jwaisner - change - 12 Mar 2020
Status Discussion Information Required
avatar joomla-cms-bot joomla-cms-bot - unlabeled - 12 Mar 2020
avatar jwaisner
jwaisner - comment - 12 Mar 2020

@wilsonge are you still looking at applying this to J3 or will this be something in J4?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14662.

avatar wilsonge
wilsonge - comment - 12 Mar 2020

I mean it should be in both versions but I'm not actively working on it. Got too many other things on my plate :(

avatar jwaisner jwaisner - change - 12 Mar 2020
Status Information Required New
avatar jwaisner
jwaisner - comment - 24 Aug 2021

@wilsonge , just bumping this as a reminder :)

avatar brianteeman
brianteeman - comment - 23 Aug 2022

Please tag J4

avatar zero-24 zero-24 - change - 23 Aug 2022
Labels Added: No Code Attached Yet J4 Issue
Removed: ?
avatar zero-24 zero-24 - labeled - 23 Aug 2022
avatar Hackwar Hackwar - change - 18 Feb 2023
Labels Added: bug
avatar Hackwar Hackwar - labeled - 18 Feb 2023
avatar Hackwar
Hackwar - comment - 28 Sep 2024

So, it's been 7 years and I just looked this up... I think this has been fixed in the meantime. Could you check this again, @wilsonge? Maybe we can finally close this?

Add a Comment

Login with GitHub to post a comment