[#14661] - [com_associations] Improving associated tip
- Fixed in Code Base
- 17 Mar 2017
- Medium
- Build: staging
- # 14661
- Diff
- infograf768:associations_tip
User tests: Successful: Unsuccessful:
In the Gsoc project the tip for associated items included more infos.
- For items, it was also showing the category it belongs to
- For menu items, it was also showing in which Menu Type it is
This PR reinstates this functionnality:
Before patch for articles (would be the same for contacts and newsfeeds)
After patch
before patch for Menu items
After patch
Testing instructions:
Create a multilingual site (from staging)
Associate some menu items and some articles/contacts/newsfeeds
Display com_associations list and choose the type and language you want to display.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_associations |
I used a space before the : as this is harcoded (Did not want to complicate this with a new string using sprintf).
Yes, this extra information is important and is similar to these icons/labels all over core (where a sprintf is used of type JText::sprintf('JCATEGORY_SPRINTF', $item->category_title)
Wait. We can use the existing sprintf strings.
On it now
| Labels |
Added:
?
|
||
We should now get this
That's better. Thanks
OT but do you think the text at the bottom is obvious enough? The edit
association stuff
On 16 Mar 2017 9:59 a.m., "infograf768" notifications@github.com wrote:
We should now get this
[image: screen shot 2017-03-16 at 10 57 16]
https://cloud.githubusercontent.com/assets/869724/23990775/5ff6a084-0a37-11e7-9cbb-4470f572f27a.png—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#14661 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8eZkoYtIXv7gE4Iu16L5b1F67lNMks5rmQgFgaJpZM4MfCBV
.
OT but do you think the text at the bottom is obvious enough? The edit association stuff
It differentiate between Add new association and Edit association. Let's keep it.
if OK, please mark test OK on ijo
No i understand what the text is for and i agree with it. I am just
questioning if it is displayed prominently enough with clarity. It makes
sense right now if you are looking atboth options together but makes less
sense when you see them on their own.
On 16 Mar 2017 10:06 a.m., "infograf768" notifications@github.com wrote:
if OK, please mark test OK on ijo
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#14661 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8XglozndD8jGBsZSkfCks_jgezRJks5rmQm7gaJpZM4MfCBV
.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14661.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14661.
| Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks for testing.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14661.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-17 09:07:11 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
It works
It should not have a space before the :
I am not convinced on the benefit for having this extra information but if you think it is useful then fine