? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
14 Mar 2017

Summary of Changes

This PR:

  • Fixes the checkboxes layout
  • Adds the switcher class to new parameters merged in from J3.7
  • Fixes the switcher input width
avatar C-Lodder C-Lodder - open - 14 Mar 2017
avatar C-Lodder C-Lodder - change - 14 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Mar 2017
Category Administration com_fields com_users Templates (admin) Layout Front End Plugins
avatar C-Lodder C-Lodder - edited - 14 Mar 2017
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 14 Mar 2017

whats the Difference between with- or without PR?

Switch (Default Page) looks same:
bildschirmfoto 2017-03-14 um 12 49 22

avatar C-Lodder
C-Lodder - comment - 14 Mar 2017

@franz-wohlkoenig

If you try and click anywhere within the red box (screenshot below), then the switcher doesn't work. This is because the element was 10px narrower than the parent.

untitled

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 14 Mar 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 14 Mar 2017

I have tested this item successfully on cdefe0f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14601.

avatar C-Lodder
C-Lodder - comment - 16 Mar 2017

@wilsonge ready to merge

avatar wilsonge wilsonge - change - 16 Mar 2017
Title
Lang
[4.0] Switcher + checkbox layout fixes
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-03-16 18:04:04
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 16 Mar 2017
avatar wilsonge wilsonge - merge - 16 Mar 2017

Add a Comment

Login with GitHub to post a comment