[#14585] - Missing translation for the new 'Components menu container' menu item type
- Fixed in Code Base
- 14 Mar 2017
- Medium
- Build: staging
- # 14585
- Diff
- joeforjoomla:staging
User tests: Successful: Unsuccessful:
Steps to reproduce the issue
Install an extension such as Virtuemart
Expected result
All values in 'Show or Hide Menu Items' are translated as the standard
Joomla admin menu
Actual result
Only item marked as COM_XXX in the XML manifest file are translated,
none of the XXX are translated
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus |
| Labels |
Added:
?
|
||
Looks like Virtuemart is not using a normal xml
<name>VIRTUEMART</name>
instead of
<name>COM_VIRTUEMART</name>
or
<name>com_virtuemart</name>
which would explain that issue.
I am looking at this now. However I believe that since the language key string comes from the component manifest itself, the translation should still work if written in the extension.
Looks like Virtuemart is not using a normal xml
The name don't need to be a translation string it can also be just text. So I think the element is the better choice here
Tested patch and, yes, this PR makes sense and will work in any case.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14585.
Yeah right. I'd too choose element against name. Not sure why I did that in the first place.
Patch is good to me.
| Status | Pending | ⇒ | Ready to Commit |
RTC. Good find!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14585.
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-14 11:11:29 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
@izharaazmi
Can you look at this?