[#14557] - WTF do these strings even mean?
- Closed
- 13 Mar 2017
- Medium
- Build: staging
- # 14557
COM_JOOMLAUPDATE_UPDATE_LOG_CONFIRM_FINALISE="The confirm for the finalise step has successfully passed."
COM_JOOMLAUPDATE_UPDATE_LOG_CONFIRM_FINALISE_FAIL="The confirm of the finalise step has failed"- These are writing to a log file. Why are we translating log messages?
- Anyone who can write these in a form of English that I might be able to read wins a beer. I'll even take Spanish at this point, my broken understanding of it is probably enough to work with.
joomla-cms-bot
- | Labels |
Added:
?
|
||
Since I'm mildly annoyed at the moment (sorry), it's not my intent to trash anyone's English. Just so it's clear. I'm just mildly annoyed chasing down ghost strings and trying to decipher messages.
I'm only doing the en-US variant on Crowdin right now and I'm struggling in places. And I'm supposed to be able to speak English (so the US school system says, others may feel differently). This isn't helping our translators.
I agree. So we can fix this by a native speaker suggests a better string and we use this. ;)
Btw it was used as language string as the other log messages in com_joomlaupdate got translated too e.g.
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_joomlaupdate/models/default.php#L315
We can also completly remove that string / translation.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-13 10:50:00 |
| Closed_By | ⇒ | brianteeman |
It come from me. Feel free to replace it with a different message. It should just show in the logs that we bypassed the token checks here.