? ? ? Pending

User tests: Successful: Unsuccessful:

avatar astridx
astridx
12 Mar 2017

Pull Request for Issue # .
#13335

Summary of Changes

  1. Changing the alias in name in database and code.
  2. changed the position of the field -> position of field alias is empty
    -> field name is shown with the options
  3. add a check, if the field name is unique

Testing Instructions

  1. Change the value in the database for the com_fields alias to name

SET SQL_MODE = "NO_AUTO_VALUE_ON_ZERO";
SET time_zone = "+00:00";

ALTER TABLE #__fields CHANGE alias name VARCHAR(255) CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT '';

(or make new installation of Joomla after applying this path).

  1. Apply this patch

  2. Create and edit Custom fields in the frontend and in the backend

Documentation Changes Required

No

avatar astridx astridx - open - 12 Mar 2017
avatar astridx astridx - change - 12 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Mar 2017
Category SQL Administration com_admin Postgresql MS SQL com_fields Language & Strings Front End com_users Installation Plugins
avatar astridx astridx - change - 13 Mar 2017
Labels Added: ? ?
avatar astridx
astridx - comment - 13 Mar 2017

Done. Thanks.
Is there a rule when we use the exclamation mark after the word Joomla?

avatar laoneo laoneo - test_item - 30 Mar 2017 - Tested successfully
avatar laoneo
laoneo - comment - 30 Mar 2017

I have tested this item successfully on 164c8d2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14554.

avatar laoneo
laoneo - comment - 30 Mar 2017

I could save the field with a different name, edit an article and change the values and checked if the values do correctly appear on the front.

avatar laoneo
laoneo - comment - 30 Mar 2017

You need to fix some code style errors to make drone happy http://213.160.72.75/joomla/joomla-cms/2006

avatar astridx
astridx - comment - 30 Mar 2017

@laoneo Thank you for testing :)
I think drone is now happy: http://213.160.72.75/joomla/joomla-cms/2053 :)

avatar laoneo laoneo - test_item - 31 Mar 2017 - Tested successfully
avatar laoneo
laoneo - comment - 31 Mar 2017

I have tested this item successfully on d336fbf


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14554.

avatar ysrostov
ysrostov - comment - 5 Apr 2017

Tested successfully with the fresh installation. I created two groups in Content menu and tried to create two custom fields in each group with similar name - checking for duplicate names is implemented and works fine.

avatar Bakual Bakual - alter_testresult - 5 Apr 2017 - ysrostov: Tested successfully
avatar Bakual Bakual - change - 5 Apr 2017
Status Pending Ready to Commit
Labels
avatar Bakual
Bakual - comment - 5 Apr 2017

Setting RTC after two tests

avatar rdeutz rdeutz - change - 5 Apr 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-04-05 07:21:09
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 5 Apr 2017
avatar rdeutz rdeutz - merge - 5 Apr 2017
avatar laoneo
laoneo - comment - 5 Apr 2017

Thanks @astridx!

Add a Comment

Login with GitHub to post a comment