Success

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
11 Jul 2013
avatar laoneo laoneo - open - 11 Jul 2013
avatar dongilbert
dongilbert - comment - 11 Jul 2013

I don't particularly agree with this. The code is there, it's not restricted to only use by templates, nor was it meant to, IMO. If it were, it would be part of a template helper file somewhere, which it isn't.

avatar laoneo
laoneo - comment - 11 Jul 2013

So now I'm totally confused!! Should it be moved to the template helper then? Which file is the template helper?

avatar betweenbrain
betweenbrain - comment - 11 Jul 2013

@laoneo I believe what @dongilbert Is saying is that this function is not restricted to only templates.

avatar laoneo
laoneo - comment - 11 Jul 2013

According to bakual and david they are...

avatar betweenbrain
betweenbrain - comment - 11 Jul 2013

I think a more accurate conclusion from that discussion would be that while any extension can load Bootstrap, even via this function, it should be left to the template to do.

What @dongilbert stated in his first response, if this function was restricted to only the template, the function would exist only in the template helper.

avatar dongilbert
dongilbert - comment - 11 Jul 2013

Who are bakual and david to state the purpose of the method? They didn't issue the Pull Requests that put the code into Joomla; I don't think they can speak towards the original intent.

(Nothing against you guys, I do appreciate your contributions on the mailing list.)

avatar betweenbrain
betweenbrain - comment - 11 Jul 2013

The way I see it, the thread on the mailing list was geared more toward discussing best practices than anything else.

avatar laoneo
laoneo - comment - 11 Jul 2013

Some people say this some that. Then close this pull request and I will go my way...Just thought it would clear things up as the conclusion of the mailing list thread was that the loadCss function should only be called from a template. Who has then the final decision to make and define the way to go?

avatar mbabker
mbabker - comment - 11 Jul 2013

We don't have the means to enforce this within the code, all we can do is call it best practice. So maybe the doc block should reflect that it's recommended that the method is only used within templates, and extended documentation (i.e. the docs wiki or when we get the API site updated) can further explain the rationale for this thinking.

Add a Comment

Login with GitHub to post a comment