[#14530] - [com_associations] Separating in list associations from not associated yet
- Fixed in Code Base
- 14 Mar 2017
- Medium
- Build: staging
- # 14530
- Diff
- infograf768:com_assoc_list
User tests: Successful: Unsuccessful:
Pull Request for Issue #14490
Summary of Changes
Separating Associated languages from not yet associated ones in the Associations list.
Testing Instructions
Create a multilingual site and associate some items. Do not associate some items for some content languages.
Before patch
After patch
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_associations Language & Strings Layout |
I am closing this patch. Issue because of the layout change in managers
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-12 14:21:43 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Added:
?
?
|
||
| Status | Closed | ⇒ | New |
| Closed_Date | 2017-03-12 14:21:43 | ⇒ | |
| Closed_By | infograf768 | ⇒ |
| Status | New | ⇒ | Closed |
| Status | New | ⇒ | Pending |
| Category | Administration com_associations Language & Strings Layout | ⇒ | Administration com_associations Language & Strings |
Corrected the managers Notice, but I get one in com_associations associations list:
"Notice: Undefined index: link in ROOT/layouts/joomla/content/associations.php on line 19"
If someone has an idea how to solve that.
Trashed issue is a separate issue it seems.
Will look at it.
Corrected the managers Notice, but I get one in com_associations associations list:
"Notice: Undefined index: link in ROOT/layouts/joomla/content/associations.php on line 19"
Can you doube check that you are on the very last version of staging? As line 19 is </li> https://github.com/joomla/joomla-cms/blob/staging/layouts/joomla/content/associations.php#L19
yep last version
Trashed Content Languages can't now be used. Thanks @brianteeman for finding that bug.
Patch not totally OK. Closing.
| Status | Closed | ⇒ | New |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ |
| Status | New | ⇒ | Pending |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14530.
I have tested this item
Patch ok for me
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14530.
| Status | Pending | ⇒ | Ready to Commit |
2 good testers. RTC.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14530.
still fails accessibility
My 2c, if you really want to improve accessibility you need to add <span class="sr-only">Indicated language: {{Language}}</span> next to each flag image, or something similar. (screen readers will read nothing in that column as is)
Oops, will be a good idea tho to run a screenreader on the page and see what fails...
and all over J, I guess...
true... :(
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-14 20:52:02 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
Layout
as you can see from the screenshots the layout looks odd because of the centre alignments - it would probably be easier to read and scan if the layout is left aligned
Trashed
I still say it is wrong to display trashed content languages in the list
I still say it fails a11y guidelines as you are using colour as a sole indicator but I can see that a11y isnt important to you