Labels |
Added:
?
|
@izharaazmi can you take a look please
In the initial feature PR I decided to display all components irrespective that they use categories or not. later in another PR it was modified to show only the components that have at least one category in the database. Please confirm this situation in your test environment.
@infograf768 Please have a look
Users doesnt have categories ;)
Also I am not convinced if we should have a separate categories type at all if we have it already in the component (sometimes). whatever is decided it must be consistent. As you can see from the screenshot below there is a category option in the Banners but not in the Articles for example
@brianteeman. See also #13902
Btw, user categories are used as notes categories, as I remember.
Then it needs to be clear it is notes categories and not categories of
users
On 15 Mar 2017 1:30 p.m., "Izhar Aazmi" notifications@github.com wrote:
Btw, user categories are used as notes categories, as I remember.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#14524 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8S7jiOTKg0f9y2K7EdeXDCbacgEWks5rl-fcgaJpZM4Maiqz
.
I want to address this type of things with my said PR. Please see if my
approach is acceptable and feasible or not.
View/layout manifest is not preset for these components:
contacts
banners
fields
finder
messages
newsfeeds
redirect
search
tags
Few will still allow creating admin menu items using component manifest as a fallback.
Should this be added as a separate issue? I'd love to do the PR but days are busy currently.
Category | ⇒ | com_admin com_menus |
Priority | Medium | ⇒ | Low |
Status | New | ⇒ | Discussion |
@izharaazmi did you make a PR?
@brianteeman can we close as we have a PR?
Status | Discussion | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-29 13:41:18 |
Closed_By | ⇒ | zero-24 |
Done
I think before closing an issue on behalf of a PR we need to evaluate
whether the PR is essentially related and fixes/covers all aspects of the
issue.
@izharaazmi that's why I tagged @brianteeman to review it :-)
In addition some components already have an option to create a category link - eg banners and contacts but some do not eg articles
It really should be consistent. Either there is a category link for each component or there is no link and you have to use the categories link as shown in the screenshot above