?
avatar brianteeman
brianteeman
12 Mar 2017

The new ability to add Admin menus allows you to create a menu link to Categories for the elected component. In the list of available components is Users. But users doesnt have categories

screenshotr13-37-30

avatar brianteeman brianteeman - open - 12 Mar 2017
avatar joomla-cms-bot joomla-cms-bot - change - 12 Mar 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 12 Mar 2017
avatar brianteeman
brianteeman - comment - 12 Mar 2017

In addition some components already have an option to create a category link - eg banners and contacts but some do not eg articles

It really should be consistent. Either there is a category link for each component or there is no link and you have to use the categories link as shown in the screenshot above

avatar brianteeman
brianteeman - comment - 15 Mar 2017

@izharaazmi can you take a look please

avatar izharaazmi
izharaazmi - comment - 15 Mar 2017

In the initial feature PR I decided to display all components irrespective that they use categories or not. later in another PR it was modified to show only the components that have at least one category in the database. Please confirm this situation in your test environment.

@infograf768 Please have a look

avatar brianteeman
brianteeman - comment - 15 Mar 2017

Users doesnt have categories ;)

Also I am not convinced if we should have a separate categories type at all if we have it already in the component (sometimes). whatever is decided it must be consistent. As you can see from the screenshot below there is a category option in the Banners but not in the Articles for example

screenshotr13-18-42

avatar izharaazmi
izharaazmi - comment - 15 Mar 2017

Users doesnt have categories ;)

image

avatar izharaazmi
izharaazmi - comment - 15 Mar 2017

@brianteeman. See also #13902

avatar izharaazmi
izharaazmi - comment - 15 Mar 2017

Btw, user categories are used as notes categories, as I remember.

avatar brianteeman
brianteeman - comment - 15 Mar 2017

Then it needs to be clear it is notes categories and not categories of
users

On 15 Mar 2017 1:30 p.m., "Izhar Aazmi" notifications@github.com wrote:

Btw, user categories are used as notes categories, as I remember.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#14524 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8S7jiOTKg0f9y2K7EdeXDCbacgEWks5rl-fcgaJpZM4Maiqz
.

avatar izharaazmi
izharaazmi - comment - 15 Mar 2017

I want to address this type of things with my said PR. Please see if my
approach is acceptable and feasible or not.

avatar izharaazmi
izharaazmi - comment - 15 Mar 2017

View/layout manifest is not preset for these components:

contacts
banners
fields
finder
messages
newsfeeds
redirect
search
tags

Few will still allow creating admin menu items using component manifest as a fallback.

Should this be added as a separate issue? I'd love to do the PR but days are busy currently.

avatar franz-wohlkoenig franz-wohlkoenig - change - 30 Mar 2017
Category com_admin com_menus
avatar franz-wohlkoenig franz-wohlkoenig - change - 4 Apr 2017
Priority Medium Low
Status New Discussion
avatar tonypartridge
tonypartridge - comment - 29 May 2017

@izharaazmi did you make a PR?

avatar izharaazmi
izharaazmi - comment - 29 May 2017

Yes, #13902 it is.

avatar tonypartridge
tonypartridge - comment - 29 May 2017

@brianteeman can we close as we have a PR?

avatar zero-24 zero-24 - change - 29 May 2017
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2017-05-29 13:41:18
Closed_By zero-24
avatar zero-24 zero-24 - close - 29 May 2017
avatar zero-24
zero-24 - comment - 29 May 2017

Done

avatar izharaazmi
izharaazmi - comment - 29 May 2017

I think before closing an issue on behalf of a PR we need to evaluate
whether the PR is essentially related and fixes/covers all aspects of the
issue.

avatar tonypartridge
tonypartridge - comment - 29 May 2017

@izharaazmi that's why I tagged @brianteeman to review it :-)

Add a Comment

Login with GitHub to post a comment