? ? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
11 Mar 2017

Summary of Changes

Allow plugin overrides via the backend template manager

Testing Instructions

  • Apply this patch
  • go to Extensions -> Templates -> Templates -> Protostar Details and Files
  • Switch to the Create Overrides tab
  • confirm there are also the plugins that you can override in that list.
  • hit the override button for plg_twofactorauth_totp
  • confirm it creates and executes the new override
  • change the view using the new override
  • confirm the new override is used.

Expected result

Plugins that supports overrides are in the list to create a override using the GUI

image

Actual result

No Plugin are in the list in the backend.

image

Documentation Changes Required

Nothing needs to be changed as there is no doku about that feature on the help screens. Maybe we should create something like this but this is a different issue and out of scope of that PR.

avatar zero-24 zero-24 - open - 11 Mar 2017
avatar zero-24 zero-24 - change - 11 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Mar 2017
Category Administration com_templates Language & Strings
avatar zero-24 zero-24 - change - 11 Mar 2017
Labels Added: ? ?
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 12 Mar 2017

@zero-24 where and how to change the view using the new override? Tried in User > Tab: Two Factor Authentication haven't found a Way to change View.

avatar dgt41
dgt41 - comment - 12 Mar 2017

@franz-wohlkoenig you will not get an option, just override the plugin edit the override and add some text. Visit the page where the plugin is displayed (e.g. login) and see if the text is there

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 12 Mar 2017

Changed Override html > plg_twofactorauth_totp from:

	<legend>
        <?php echo JText::_('PLG_TWOFACTORAUTH_TOTP_STEP1_HEAD') ?>
	</legend>

to

	<legend>
        My 2FA
        <?php echo JText::_('PLG_TWOFACTORAUTH_TOTP_STEP1_HEAD') ?>
	</legend>

Couldn't see "My 2FA" in "Users: Edit > Tab 'Two Factor Authentication':
bildschirmfoto 2017-03-12 um 10 44 26

avatar zero-24
zero-24 - comment - 12 Mar 2017

Did you check in the frontend template? If we override in protostar there is no change in isis ;)

avatar dgt41
dgt41 - comment - 12 Mar 2017

@ciar4n @C-Lodder can you check if we can redesign this page to something more decent than the 3 columns?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 12 Mar 2017

@zero-24 i looked at login, theres a "Secret key" new, but its the Module so i don't know where i can see the View.

avatar zero-24
zero-24 - comment - 12 Mar 2017

You can go to your user profiel in the frontend. There is the view that you can change with that override.

avatar ciar4n
ciar4n - comment - 12 Mar 2017

@dgt41 To be fair the current layout is functional. One alternative might be to create a btn-group with 'showon' for each of the columns....

override

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 12 Mar 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 12 Mar 2017

I have tested this item successfully on c3acd81


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14503.

avatar brianteeman
brianteeman - comment - 12 Mar 2017

You will need to update the hathor template overrides as well

avatar joomla-cms-bot joomla-cms-bot - change - 12 Mar 2017
Category Administration com_templates Language & Strings Administration com_templates Language & Strings Templates (admin)
avatar zero-24
zero-24 - comment - 12 Mar 2017

You will need to update the hathor template overrides as well

Hathor is done. Thansk for the hint @brianteeman

image

avatar zero-24
zero-24 - comment - 4 Apr 2017

Any feedback on this one? Should this be tested / implemented or just closed?

avatar brianteeman
brianteeman - comment - 4 Apr 2017

With the rise of fields i think this is a good idea. But I dont think we can progress with it.

In the UI as you are presented the ability to create overrides of all plugins when you have a front end template selected - you shouldnt be able to override the installer plugins here AND the same when you have an admin template selected - you shouldnt be able to override the content plugins here.

With the current plugin architecture I dont think we have a way to determine if it is for frontend or admin though :(

avatar mbabker
mbabker - comment - 4 Apr 2017

Plugins aren't app specific and I would heavily downvote any code that tries to add that distinction personally. It's already goofy enough that we have the ability to create admin/site specific modules versus those being app agnostic (especially when the underlying code is in essence the same thing, check the two feed modules).

With that said though, maybe the compromise to this is a way to allow plugins to hook into this process. Because plugins are doing layouts in all sorts of different ways (at least with core there are a couple using JLayout and a couple using the tmpl directory processed with JPluginHelper), and because extension developers may have their own logic predating the plugin layout support in JPluginHelper, this might be the most flexible option.

avatar brianteeman
brianteeman - comment - 4 Apr 2017

I am just commenting on the user experience of the list of plugins presented to them.

avatar zero-24
zero-24 - comment - 4 Apr 2017

ok closing for the reasons above. Thanks for the feedback and the testers!

avatar zero-24 zero-24 - change - 4 Apr 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-04-04 20:38:47
Closed_By zero-24
avatar zero-24 zero-24 - close - 4 Apr 2017

Add a Comment

Login with GitHub to post a comment