[#14488] - Removed the save warning option in TinyMCE editor setting
- Fixed in Code Base
- 15 Jun 2017
- Medium
- Build: staging
- # 14488
- Diff
- shivamdiehard:removesavewarning
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue https://issues.joomla.org/tracker/joomla-cms/14466 .
Summary of Changes
Removed the Save Warning option in TinyMCE editor plugin option.
Testing Instructions
- Apply the patch.
- Go to add new article
- Make some changes in the editor and try to navigate away without saving
Result
The Save warning will still come.
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
Did you type something in the editor before moving away??. I think the warning should come.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14488.
"Moving away" means "Close Tab", not as i suggest click on "Close"-Tab.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14488.
Moving away/Navigate away means clicking on back button after you have made changes into editor
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14488.
I have tested this item
Either clicking back button in the browser, either trying to close it, this patch still shows the warning.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14488.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
@shivamdiehard could you please fix the conflicts, thanks
Don't we need to deprecate the strings too?
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-15 06:53:38 |
| Closed_By | ⇒ | rdeutz |
Now we merged it without deprecation?
I reviewed the change before and missed that now zero files are changed, but the good site of it is, it can't break things :-)
I have tested this item? unsuccessfully on 95265cb
"Save Warning"-Option is removed from Plugin, but no Warning is still coming.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14488.