? Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
11 Mar 2017

Pull Request for Issue # .

Summary of Changes

See #14467 for issue description. Look at JFormFieldCaptcha, the intention is implements JFormDomfieldinterface . However, that interface is not defined anywhere in our codebase (both Joomla 3 and Joomla 4). Since @laoneo said that the interface was abandon long time ago and this is the only Form Field has this implements JFormDomfieldinterface, I think we just need to remove the implements JFormDomfieldinterface from class definition

Testing Instructions

See #14467 and confirm the issue. Apply patch and confirm the issue fixed

avatar joomdonation joomdonation - open - 11 Mar 2017
avatar joomdonation joomdonation - change - 11 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Mar 2017
Category Libraries
avatar zero-24
zero-24 - comment - 11 Mar 2017

hmm looks like there was a merge conflict between staging and 4.0-dev ?

https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/form/field/captcha.php#L17

avatar zero-24
zero-24 - comment - 11 Mar 2017

Merging on review. As it is clearly a error. Thanks @joomdonation

avatar zero-24 zero-24 - change - 11 Mar 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-03-11 10:27:35
Closed_By zero-24
Labels Added: ?
avatar zero-24 zero-24 - close - 11 Mar 2017
avatar zero-24 zero-24 - merge - 11 Mar 2017

Add a Comment

Login with GitHub to post a comment