[#14458] - [com_fields] Add support for max length for text and textarea
- Fixed in Code Base
- 30 Mar 2017
- Medium
- Build: staging
- # 14458
- Diff
- Digital-Peak:cf/max-length
User tests: Successful: Unsuccessful:
Pull Request for Issue #14374.
Summary of Changes
Adds the max length parameter to the text and textarea custom field. Additionally it fixes a bug in the maxlength parameter of the JLayout of the textarea field.
Testing Instructions
- Create a text custom field for articles.
- Set the max length parameter to 2.
- Save an close the field.
- Edit an article.
Expected result
It should not be possible to add more than 2 characters into the text field when editing the article.
Actual result
The max length parameter is not available as it is a new feature.
Documentation Changes Required
Adding the max length parameter description to the text and textarea field in the documentation pages.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields Language & Strings Layout Front End Plugins |
| Labels |
Added:
?
?
|
||
Changed. Perhaps somebody should change the docs as well https://docs.joomla.org/Text_form_field_type.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14458.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14458.
COnflicts solved.
@coolcat-creations and @franz-wohlkoenig can you please re-test?
Again conflicts solved, can we set this one to RTC?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14458.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14458.
RTC as there are 2 successfully Tests?
Just merged staging into this branch, can be set to RTC.
I have tested this item
After patch installation I can see a single query for all custom fields ( as opposed to a separate query for each custom field before the patch).
However ,I just want to point out ( though this is a different issue) that the fields are displayed quite messy and improperly , mostly in the front-end. This may have to do with me not knowing properly the management of custom fields...
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14458.
Sorry , my mistake. My post was intended for #14558 .
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14458.
Can we set this one to RTC as well?
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14458.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-30 21:28:12 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 4eccfc1
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14458.