? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
10 Mar 2017

the description of the fields plugins that was merged in 13750 is not correct english

this PR rewrites them into correct English

This doesnt affect translations as presumably they wrote their translations correctly

avatar brianteeman brianteeman - open - 10 Mar 2017
avatar brianteeman brianteeman - change - 10 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Mar 2017
Category Administration Language & Strings
avatar infograf768
infograf768 - comment - 10 Mar 2017

If you want to change, OK, BUT please normalise to use lowercase for the 'calendar' as this does NOT depend on English Grammar: it is the Type of the field in code.
Therefore, should be:
PLG_FIELDS_CALENDAR_XML_DESCRIPTION="This plugin lets you create new fields of type 'calendar' in any extensions where custom fields are supported."

This is what we have done for all PLG_FIELDS_

avatar infograf768
infograf768 - comment - 10 Mar 2017

Example in French, we do not translate 'calendar':
PLG_FIELDS_CALENDAR_XML_DESCRIPTION="Ce plugin permet de créer de nouveaux champs de type 'calendar' dans les extensions où les champs personnalisés sont implémentés."

avatar RonakParmar
RonakParmar - comment - 10 Mar 2017

Found "No newline at end of file" in below file:

avatar brianteeman brianteeman - change - 10 Mar 2017
Labels Added: ? ?
avatar brianteeman
brianteeman - comment - 10 Mar 2017

@infograf768 updated to use lowercase for calendar even though it was beyond the scope of this PR as it was originally committed incorrectly - I guess you didn't spot it before ;)

@RonakParmar done

avatar RonakParmar RonakParmar - test_item - 10 Mar 2017 - Tested successfully
avatar RonakParmar
RonakParmar - comment - 10 Mar 2017

I have tested this item successfully on 480296b

Done code review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14447.

avatar infograf768
infograf768 - comment - 10 Mar 2017

I guess you didn't spot it before

It was indeed modified in a more recent committed PR and yep, I did not spot that one.

It was modified here:
#13638

while it was correct here:
#13710

avatar wilsonge wilsonge - change - 10 Mar 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-03-10 19:32:25
Closed_By wilsonge
avatar wilsonge wilsonge - close - 10 Mar 2017
avatar wilsonge wilsonge - merge - 10 Mar 2017
avatar wilsonge
wilsonge - comment - 10 Mar 2017

I'm good with this too so merged :)

Add a Comment

Login with GitHub to post a comment