User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Related to #5544
Main Improvement:
published
is re-calculated on every save, change state, move or copy for #__categories
and #__menu
(in general for subclasses of JTableNested).In order to not display unpublished categories on front end old installation has to call additional query.
That query re-calculates published
column for whole tree.
After apply patch on exists installation you have to run 2 queries from:
[Chose your database]
* administrator/components/com_admin/sql/updates/mysql/3.7.0-2017-03-09.sql
* administrator/components/com_admin/sql/updates/postgresql/3.7.0-2017-03-09.sql
* administrator/components/com_admin/sql/updates/sqlazure/3.7.0-2017-03-09.sql
Old behaviour:
New bevaviour
published
column of children items is changed based on the rules.Test categories, menus and articles on front end and on back end.
[UPDATED]
All above points should follow the rules.
Joomla should work as before but faster on frontend views: featured/blog/list/archived/article and on others which use model from components/com_content/models/articles.php
like mod_articles...
On front end with lots of categories and articles Joomla works slow.
I do not know.
Special subquery (badcats) for nested tables are now not required.
The new rules in JTableNested
which change published state for children.
Status | New | ⇒ | Pending |
Category | ⇒ | SQL Administration com_admin Postgresql MS SQL Front End com_contact com_content Libraries |
Labels |
Added:
?
|
Category | SQL Administration com_admin Postgresql MS SQL Front End com_contact com_content Libraries | ⇒ | SQL Administration com_admin Postgresql MS SQL Front End com_contact com_content Libraries Unit Tests |
Labels |
Added:
?
|
I have tested this item
Tested (Back- and if possible Frontend):
Just as a pass by comment. How was the old behavior? We need to make sure we don't introduce here a different behavior than it was before. Perhaps it is better to target this PR against J4?
Old behaviour IMO is incomplete (category, menu):
I have updated a description to be more understandable.
I have tested this item
On category list of 100 articles (out of 10.000) I get 13% decrease in categories stats query and 6% on articles query. Behaviour seems much more consistent now
RTC as there are 3 successfully Tests?
Title |
|
Status | Pending | ⇒ | Ready to Commit |
Labels |
RTC
Some code style issues needs fixing
Code Style error does not belong to this PR. Take a look at 5d4539a#diff-283548acdd3d39b1c48e6779d916336dR246
Ok, merging the other one we CI processes done
Title |
|
||||||
Status | Ready to Commit | ⇒ | Fixed in Code Base | ||||
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-30 22:10:46 | ||||
Closed_By | ⇒ | rdeutz | |||||
Labels |
Added:
?
|
After save new Menu (Smart Search) got:
Menu is saved. Save Articles and Categories works.