?
avatar ghasemy50
ghasemy50
7 Mar 2017

Steps to reproduce the issue

you can check all sections that have calendar in persian language.
install Persian language and test a section that have calendar, like modules

Expected result

show jalali calendar correctly

Actual result

show jalali calendar not correctly

Additional comments

before release stable version of joomla 3.7 please resolve this problem.
thank you

avatar ghasemy50 ghasemy50 - open - 7 Mar 2017
avatar joomla-cms-bot joomla-cms-bot - labeled - 7 Mar 2017
avatar Bakual
Bakual - comment - 7 Mar 2017

@dgt41 Can you have a look? It looks indeed broken a lot.

avatar dgt41
dgt41 - comment - 7 Mar 2017

the css part you mean or the functional?

avatar Bakual
Bakual - comment - 7 Mar 2017

I think there is at least some functional stuff broken:

persian

avatar dgt41
dgt41 - comment - 7 Mar 2017

Do they have in their language file the translate options?

@Bakual I mean

DATE_FORMAT_CALENDAR_DATE="%Y-%m-%d"
DATE_FORMAT_CALENDAR_DATETIME="%Y-%m-%d %H:%M:%S"
DATE_FORMAT_FILTER_DATE="Y-m-d"
DATE_FORMAT_FILTER_DATETIME="Y-m-d H:i:s"
avatar zero-24 zero-24 - change - 7 Mar 2017
Labels Added: ?
avatar zero-24 zero-24 - labeled - 7 Mar 2017
avatar Bakual
Bakual - comment - 7 Mar 2017

I tested with the one available from the backend. I have no clue what they have in their 3.7.0. Maybe @infograf768 knows more.

But even if that is missing in their pack, shoudn't it then fall back to the english format? That's how our language strings usually work.

avatar dgt41
dgt41 - comment - 7 Mar 2017

Ok found it: their missing the <calendar>jalali</calendar> in their xml file. After that everyhting works as usual. Can you ask them to release a new version of their language with the update values for the xml?

screen shot 2017-03-07 at 23 37 39

avatar zero-24 zero-24 - change - 7 Mar 2017
Labels Removed: ?
avatar zero-24 zero-24 - unlabeled - 7 Mar 2017
avatar dgt41
dgt41 - comment - 7 Mar 2017

@zero-24 there is nothing wrong with the calendar, the error comes from their old localisation files, so no release-blocker here. Maybe force them to release an update with only the missing part of the xml to make sure that people won't get into this screen ever!

avatar zero-24
zero-24 - comment - 7 Mar 2017

I have just removed the label and the milestone ;)

image

So we can close here if we hear back from Thomas / the TT ;)

avatar dgt41
dgt41 - comment - 7 Mar 2017

It's getting late...
I really like the idea that they would release a minor update to their language pack with only the missing part of the xml, but up to them and Thomas

avatar Bakual
Bakual - comment - 7 Mar 2017

They will release it when 3.7.0 is released. That is standard procedure. Doesn't make much sense to release it now since nothing is broken on a released version yet. ?

@ghasemy50 Can we close this issue as it is something that has to be done on language pack side?

avatar ghasemy50
ghasemy50 - comment - 8 Mar 2017

thanks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14411.

avatar ghasemy50
ghasemy50 - comment - 8 Mar 2017

i'm tested it ,but after save , date has been deleted from date field.

in previous versions of joomla , date field value was converted to gregorian , then it was saving.

i think now it is saving jalali date and have problem.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14411.

avatar dgt41
dgt41 - comment - 8 Mar 2017

@ghasemy50 the new calendar is also doing the same, converts the date to gregorian just before the form submit. what was your component that failed?

avatar ghasemy50
ghasemy50 - comment - 8 Mar 2017

jalali calendar problem
all readonly fields are correctly work.
but all date fields that have calendar box on save, not convert to gregorian date and after save are show field blank.
thanks.

avatar infograf768
infograf768 - comment - 8 Mar 2017

I really like the idea that they would release a minor update to their language pack with only the missing part of the xml, but up to them and Thomas

mig already asked them. will make sure a new pack is released to cover the issue in the mean while

avatar dgt41
dgt41 - comment - 8 Mar 2017

@ghasemy50 I'm guessing that it fails due to missing strings in your language:

DATE_FORMAT_CALENDAR_DATE="%Y-%m-%d"
DATE_FORMAT_CALENDAR_DATETIME="%Y-%m-%d %H:%M:%S"
DATE_FORMAT_FILTER_DATE="Y-m-d"
DATE_FORMAT_FILTER_DATETIME="Y-m-d H:i:s"

PS. These are from en-GB, and should reflect the local settings for Persia.

avatar infograf768
infograf768 - comment - 8 Mar 2017

@dgt41
i don't think so. will test later

avatar ghasemy50
ghasemy50 - comment - 8 Mar 2017

i added it in fa-ir.ini file but not solved.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14411.
avatar ghasemy50
ghasemy50 - comment - 8 Mar 2017

thanks , Where do I put it?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14411.

avatar dgt41
dgt41 - comment - 8 Mar 2017

Just replace media/system/js/fields/calendar.min.js and try it

avatar ghasemy50
ghasemy50 - comment - 8 Mar 2017

thank you very much,
it's ok.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14411.

avatar infograf768
infograf768 - comment - 8 Mar 2017

@Fedik @dgt41
I confirm the issue.
After save whatever was entered in "Finish Publishing" and "Created date" displays the field empty.

avatar infograf768
infograf768 - comment - 8 Mar 2017

Release Blocker!

avatar dgt41
dgt41 - comment - 8 Mar 2017
avatar infograf768
infograf768 - comment - 8 Mar 2017

On it

avatar infograf768
infograf768 - comment - 8 Mar 2017

It solves the issue here. :
I am now uploading an improved Persian pack with the right xml

avatar dgt41
dgt41 - comment - 8 Mar 2017

Excellent, I'll try to fix also #14341 and then do a PR for both.

avatar ghasemy50
ghasemy50 - comment - 8 Mar 2017

hi again
just a tip:
'fa-ir.js' file in \media\system\js\fields\calendar-locales have a bad translate.
exit parameter is translated to 'ستن' , good translate is 'بستن'.
please correct it in joomla 3.7 stable , thank you

avatar infograf768 infograf768 - change - 10 Mar 2017
Status New Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-03-10 08:39:37
Closed_By infograf768
avatar joomla-cms-bot joomla-cms-bot - close - 10 Mar 2017
avatar joomla-cms-bot
joomla-cms-bot - comment - 10 Mar 2017

Add a Comment

Login with GitHub to post a comment