[#14407] - [com_fields] Don't default to all user fields to show
- Fixed in Code Base
- 30 Mar 2017
- Medium
- Build: staging
- # 14407
- Diff
- Digital-Peak:cf/contact-no-default-users
User tests: Successful: Unsuccessful:
Pull Request for Issue #14392.
Summary of Changes
Don't default to all user groups to show on contact fields. Like it is now it is not possible to prevent to show the user custom fields on the contact details. This pr removes the hardcoded default value "All".
Testing Instructions
Clear the "Show User Custom Fields" option in the contact options.
Expected result
Keep empty.
Actual result
Defaults the value to "All".
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_contact |
| Title |
|
||||||
See the reason and what is happening https://www.screencast.com/t/dDPWttlRH
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14407.
I don't have flash
Not sure @laoneo
If I empty the field and save I get the broken cut text. If I load the options initially the "All"is given in the field entry. Changing it to empty and successively saving and reloading gives that behavior. So not sure actually what should be shown after empty and save.....should it show "all" or empty (with correct text)
Correct works as expected for the prevention so will change the test result Thanks Allon
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14407.
I have tested this item
The userfields are still show, although nothing is selected
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14407.
Is it empty in the menu configuration and the global contact options?
Yes both are empty, also created a completely new one as the existing failed, but also no luck
I have tested this item
I created a user field group called testgroup
I create a user text field called textfield
I created a contsct and linked it to a user
I created a menu item to display a single contact
I checked that the option field did not have a category set
The contact is displayed on the front end with both the group and its fields
Just a guess but instead of having it blank would it not be better to have a NONE setting
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14407.
| Labels |
Added:
?
|
||
The important point is that the setting in the global contact options is not defaulted to all. So make sure that you can save it with no value selected and it stay like that:
As soon as I select a group or All, then the fields do show up, but when none is selected, then no fields should be shown.
As stated above in my report it is not enough for the options page to show no value. it actually has to work in that way which it doesnt
I'v just tested it with your instructions and when the field is empty, then it shows no fields on the contact page. So for me it is working as expected. I'v just tested it with the latest staging.
ok let me test again with latest staging
Ignore me I was being an idiot. All good
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-27 11:17:55 |
| Closed_By | ⇒ | brianteeman |
| Status | Closed | ⇒ | New |
| Closed_Date | 2017-03-27 11:17:55 | ⇒ | |
| Closed_By | brianteeman | ⇒ |
| Status | New | ⇒ | Pending |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14407.
Glad to hear.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14407.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful testes.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-30 21:22:21 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I have tested this item? unsuccessfully on d140e0f
I have tested this unsuccessfully See https://www.screencast.com/t/dDPWttlRH
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14407.