? ? ? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
7 Mar 2017

Pull Request for Issue #14362.

Summary of Changes

Changes the default text of the user custom field.

Testing Instructions

Create a user custom field.

Expected result

The following default text should be shown:

Default Users

With the tooltip:

A comma separated list of user ids.

Actual result

The standard text of com_fields is shown.

Documentation Changes Required

avatar laoneo laoneo - open - 7 Mar 2017
avatar laoneo laoneo - change - 7 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Mar 2017
Category Administration Language & Strings
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 7 Mar 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Mar 2017

I have tested this item successfully on 78b2b23


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14404.

avatar zero-24 zero-24 - change - 7 Mar 2017
Title
[comf_fields] Change the default value text of the user field
[com_fields] Change the default value text of the user field
avatar zero-24 zero-24 - edited - 7 Mar 2017
avatar coolcat-creations coolcat-creations - test_item - 8 Mar 2017 - Tested successfully
avatar coolcat-creations
coolcat-creations - comment - 8 Mar 2017

I have tested this item successfully on 78b2b23

Thank you Allon! Works


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14404.

avatar laoneo
laoneo - comment - 8 Mar 2017

Also RTC.

avatar infograf768
infograf768 - comment - 8 Mar 2017

please alpha order the strings. if you do not, we will have another pr...

avatar laoneo laoneo - change - 9 Mar 2017
Labels Added: ? ?
avatar laoneo
laoneo - comment - 9 Mar 2017

Done, but for me it looks awkward to have first the strings of another extension I'm overwriting.

avatar infograf768 infograf768 - change - 10 Mar 2017
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 10 Mar 2017

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14404.

avatar Twincarb
Twincarb - comment - 10 Mar 2017

This language string doesn't make a lot of sense:
PLG_FIELDS_USER_XML_DESCRIPTION="This plugin lets create new fields of type 'user' in the extensions where custom fields are implemented."

This plugin allows you to create new fields of the type....

is probably better


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14404.

avatar brianteeman
brianteeman - comment - 10 Mar 2017

@Twincarb the string was changed in #14447

avatar wilsonge wilsonge - change - 14 Mar 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-03-14 11:31:06
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 14 Mar 2017
avatar wilsonge wilsonge - merge - 14 Mar 2017
avatar brianteeman
brianteeman - comment - 16 Mar 2017

Looks like this PR is wrong a it is changing the default value for all field types not just Users see #14674

Add a Comment

Login with GitHub to post a comment