[#14400] - [Isis] Template.less refactoring
- Fixed in Code Base
- 8 Mar 2017
- Medium
- Build: staging
- # 14400
- Diff
- ciar4n:less-refactor1
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This PR starts a process of refactoring the Isis template.less, proposing to split the template.less in separate less files. Currently the template.less looks like a long list of PRs with no real structure (with the exception of its initial creation). Breaking it in to its separate components (blocks) makes for more manageable code.
blocks
| _global.less
| _chzn-override.less
| _editors.less
| _forms.less
| _header.less
| _login.less
| _media.less
| _modals.less
| _navbar.less
| _quickicons.less
| _sidebar.less
| _status.less
| _tables.less
| _toolbar.less
| _treeselect.less
| _utility-classes.less
| _custom.less
pages
| _com_cpanel.less
| _com_postinstall.less
| _com_templates.less
template.less
Testing Instructions
Apply patch a check admin for issues. Although I suspect not, it may cause some cascading issues and would require a thorough testing.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
There's still 2 and a half years support life for 3.x most likely, I think it's worth it. Granted we hope there aren't many styling changes left at this point, but that's still a large enough chunk of time that something which makes maintaining the current resources a bit easier should be considered.
I think with better grouping, the resource will be easier to optimize and troubleshoot correctly. The current structure results in a bit of a hornets nest one pokes at their own peril. I'll finish what I started and it can be decided from there.
| Labels |
Added:
?
|
||
| Title |
|
||||||
PR is now complete.
Notes
- 'global' is first with remaining in alphabetical followed by 'custom' last.
- 'custom' contains all hacks and fixes
- Media queries have been (largely) split and are coupled with their corresponding elements. This I believe makes issues more apparent and easier to fix
- Ordering with in each block has been kept
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14400.
Thank you @franz-wohlkoenig
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14400.
Isis still working as expected
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14400.
RTC as there are 2 successfully Tests?
| Status | Pending | ⇒ | Ready to Commit |
RTC
Has this been tested with RTL?
I am asking because I see no trace of
@import "../../../../media/jui/less/bootstrap-rtl.less";
@infograf768 I did install http://joomlacode.org/gf/download/frsrelease/20444/163708/ar-AA_joomla_lang_full_3.6.5v2.zip, set it to default in administrator and it seems to work well with Arabic (seems to since I do not master Arabic ;-) But the template is running well for sure RTL
@infograf768 This wouldn't have any effect on RTL as the template-rtl.css would cascade over any changes in this PR (template.css).
Once corrected, we should have
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-08 15:16:35 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thank you @infograf768
PR created.. #14421
Do we still want to touch that, when we hopefully after 3.7 focus on J4?