? ? Pending
Referenced as Related to: # 15088

User tests: Successful: Unsuccessful:

avatar ciar4n
ciar4n
7 Mar 2017

Pull Request for Issue #14397 .

Summary of Changes

Applies #12643 to Protostar

Testing Instructions

Apply patch. In Article: Options set 'Frontend Images and Links' ('Editing Layout' tab) to Yes.

Select a Intro- or Full-Article-Image at Frontend

Before Patch

image-frontend1

After Patch

image-frontend3

Documentation Changes Required

None

avatar ciar4n ciar4n - open - 7 Mar 2017
avatar ciar4n ciar4n - change - 7 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Mar 2017
Category Front End Templates (site)
avatar ciar4n ciar4n - change - 7 Mar 2017
Title
[Protostar] Protostar media modal image select
[Protostar] Media modal image select
avatar ciar4n ciar4n - edited - 7 Mar 2017
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 7 Mar 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Mar 2017

I have tested this item successfully on 7d7ce63

Thanks @ciar4n


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14398.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Mar 2017

@ciar4n is it an Accident that select an Image (move Curser over path shows "not allowed") is different to 3.6.5?

avatar dgt41
dgt41 - comment - 7 Mar 2017

@franz-wohlkoenig do you have an image in the field or the field is empty? Does it happen with an image selected?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Mar 2017

3.7:

3 7

3.6.5:

3 6 5

avatar dgt41
dgt41 - comment - 7 Mar 2017

@franz-wohlkoenig this might be my mistake here! Can you confirm that in 3.6.5 you can insert an image by typing the path? Then I will make a PR to fix this...

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Mar 2017

in 3.6.5 you can copy and paste path from intro- to full-images, was handy.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Mar 2017

it worked in Front- and Backend.

avatar dgt41
dgt41 - comment - 7 Mar 2017

Can you edit
https://github.com/joomla/joomla-cms/blob/staging/layouts/joomla/form/field/media.php#L167
and remove the . 'readonly="readonly"' part? Is everything ok?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Mar 2017

changed local on latest staging, Issue is the same.

avatar dgt41 dgt41 - test_item - 7 Mar 2017 - Tested successfully
avatar dgt41
dgt41 - comment - 7 Mar 2017

I have tested this item successfully on 7d7ce63


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14398.

avatar dgt41 dgt41 - change - 7 Mar 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Mar 2017

RTC as there are 2 successfully Tests?

avatar wilsonge wilsonge - change - 9 Mar 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-03-09 16:42:51
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge wilsonge - close - 9 Mar 2017
avatar wilsonge wilsonge - merge - 9 Mar 2017
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 4 Apr 2017

@dgt41 can you please have a look #15088 (we talked about above)

Add a Comment

Login with GitHub to post a comment