PR-staging ?

Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
4 Mar 2017

Pull Request for Issue #14301 .

Summary of Changes

This just removes the error surpressing @-sign in the router of com_finder. This is a rather dodgy way to code this.... This should only be a codereview.

avatar Hackwar Hackwar - open - 4 Mar 2017
avatar Hackwar Hackwar - change - 4 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Mar 2017
Category Front End com_finder
avatar joomdonation joomdonation - test_item - 4 Mar 2017 - Tested successfully
avatar joomdonation
joomdonation - comment - 4 Mar 2017

I have tested this item successfully on ccc00b9

code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14323.

avatar Hackwar
Hackwar - comment - 4 Mar 2017

I have to apologise. I forgot the attribution. This is basically the code from @stAn47, so all praise belongs to him. 😉

avatar PhilETaylor
PhilETaylor - comment - 4 Mar 2017

Who committed code with @ suppressors in the first instance? They should be shot!

avatar Hackwar
Hackwar - comment - 4 Mar 2017

That code is the initial commit of com_finder.

avatar PhilETaylor
PhilETaylor - comment - 4 Mar 2017

No comment

avatar alikon alikon - test_item - 7 Mar 2017 - Tested successfully
avatar alikon
alikon - comment - 7 Mar 2017

I have tested this item successfully on ccc00b9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14323.

avatar jeckodevelopment jeckodevelopment - change - 7 Mar 2017
Status Pending Ready to Commit
avatar jeckodevelopment
jeckodevelopment - comment - 7 Mar 2017

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14323.

avatar wilsonge wilsonge - change - 8 Mar 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-03-08 15:17:25
Closed_By wilsonge
Labels Added: PR-staging ?
avatar wilsonge wilsonge - close - 8 Mar 2017
avatar wilsonge wilsonge - merge - 8 Mar 2017

Add a Comment

Login with GitHub to post a comment