Questions about Test Instructions:

Go to backend and create a new article, go to permissions tab and check if permissions are sets as 'inherit'.

Check in each User Group for each Action?

After save it should stay as 'inherit'.

same as above.

If you set 'inherit' for group ex. Manager then it should not reset permissions for other groups.

sounds like this is the Problem but on testing i see no "reset permissions for other groups"

I don't understand the Issue and what to test.

@franz-wohlkoenig Some time ago I had a bug which reset permission to 'inherit' for other user groups if I only changed permission to 'inherit' for only one user group.

Ex. of old bug:
In article edit, permission tab, set permission for Edit to "Allowed" for Manager and Publisher.
After save article, change permission for Edit to "Inherit" for only Manager and save.
Now check if permission for Publisher is still Allowed and not 'Inherit'.

@csthomas will test today, thanks for Infos.

Using default user groups:

and work your Example:

In article edit, permission tab, set permission for Edit to "Allowed" for Manager and Publisher.
After save article, change permission for Edit to "Inherit" for only Manager and save.
Now check if permission for Publisher is still Allowed and not 'Inherit'.

with and -out PR got in Manager: Inherited and in Publisher: Allowed (different Trees).

Creating an Article (before Save) all Groups are inherited.

@franz-wohlkoenig I have made a new better test instruction. Please test again.

thanks @csthomas will test later.

12. Action Edit is as 'Allowed'. Change it to 'Inherit' and Save.

After Save Action Edit is set on Inherited. A Difference to Instructions the sad it is Allowed.

Allowed should be preserved/not changed on different user group permission.

Manager and Editor has the same value 'Allowed' for Edit action field.
Now you change for Editor this field to 'Inherit' and check if only this field has been changed and second one still is as 'Allowed'.

Group Editor has Setting Inherited, not Allowed like wrote in Instructions (thanks for clear Instructions).

I suppose you do not understand me, May be I explained it in a wrong way:
Please test again points 10..13:

• on patched joomla, on some existed article, only Edit action is important.
• for Editor and Manager user group

On start, these two user groups has to be set as "Allowed".
As we have "Allowed" saved we can go to next step.

Change permission to "Inherit" for only one user group and save.
After that one (changed) user group should be as 'Inherit' and second should stay as 'Allowed'.

Looks like misunderstanding, i try in another Words:

11. Change tab to user group 'Editor': Action Edit is as 'Allowed'. Change it to 'Inherit' and Save.

I understand that opening Usergroup Editor Action Edit ist set on Allowed, but its set on Inherited:

12. Action Edit is as 'Allowed'. Change it to 'Inherit' and Save.

So this is not possible cause Inherited set.

I understand that opening Usergroup Editor Action Edit ist set on Allowed, but its set on Inherited

But before you have to toggle to Manager tab check that.

You have to do changes in Editor, but check Manager.
When you save setting for Editor group with 'Inherit' value then php code do some clean up for array, and should not erase too much. I means should not change settings for other user group like Manager.

I have tested this item ✅ successfully on 08d10b2

Thanks for your patience :)

Thanks for your patience too ;-)

I have tested this item ✅ successfully on 08d10b2

Great PR, thanks!

RTC after two successful tests.

After updating to 3.7.3, we got "Invalid parent ID" for our own JTable. Is this commit related?

@olleharstedt please open a new issue, comments on closed/merged PR get lost

Please open a new issue, but meantime:

You may try to revert libraries/joomla/table/asset.php for test or other files too to version from 3.7.2, but the reason is that in your db table #__assets does not exist parent row.

Check your table and find which assets rows has invalid parent_id, means parent_id points to not existed row id.

Example query:

SELECT a.* FROM `#__assets` a LEFT JOIN `#__assets` b ON a.parent_id = b.id WHERE b.id IS NULL 

The correct result is only one row with name = 'root.1'.

Thank you.

@csthomas Query checks out, only returns root.1.