Joomla! Issue Tracker | Joomla! CMS #14305 - Fix path matching for exclusion during Joomla release packaging.

? Information Required

Closed
21 Mar 2022
Medium
Build: staging
# 14305
Diff
izharaazmi:build-update-path-resolve

Pending

Pending continuous-integration/drone/pr this build is pending Details
Success hound No violations found. Woof! Details
Success continuous-integration/travis-ci/pr The Travis CI build passed Details
Success continuous-integration/appveyor/pr AppVeyor build succeeded Details

User tests: Successful: Unsuccessful:

izharaazmi
2 Mar 2017

Summary of Changes

Fix path matching for exclusion during Joomla release packaging.

Currently we have lists of files and folders in build.php packaging script for do not package and do not patch which allows us to skip certain files from being included in the release packages.
Current comparison logic only compares the first level of subdirectory and not above it. Therefore any exclusion directive for a path like /administrator/logs will be simply ignored and it will be included in the package anyway.
This PR fixes this issue and lets us exclude by defining any level of path e.g. - /path/level/three as well.
Refactor file names for the archives into a variable and reuse it for each archive format - improves readability.

We ship our release packages in tar.gz, tar.bz2 and zip formats each having same base filename.
With this PR, we calculate the file name once only and reuse it for each archive format.

Testing Instructions

Edit the build.php file to add /administrator/language in the $doNotPackage array.
Execute the script to build a release package.
Do not forget to follow the given instruction in the top of the script.php file itself.

Expected result

The language folder from the backend should be excluded and should not be present in the prepared package.

Actual result

The language folder from the backend is NOT excluded and it is still present in the prepared package.
After this patch you will need to add /administrator/language/ (notice the trailing slash) and then we'll get the expected result.