? ? Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
1 Mar 2017

This module shows a list of the currently Logged-in Users.
So giving it a title of LAST Logged-in Users is incorrect as that would be a list of the last x users who have logged in and might not be logged in anymore.

Summary of Changes

Changes the language strings to more accurately describe what the module does.

Testing Instructions

  • Create an admin module of type "Logged-in Users" and assign it to the cpanel position (or use the existing one)
  • Enable the "Automatic Title" module option (in Advanced tab)
  • Check the title of the module in the Control Panel
  • Change the "Count" module option and verify that the module title adjusts:
    "0" should give "Logged-in Users"
    "1" should give "Logged-in User"
    "5" should give "5 Logged-in Users"

Disclaimer

Work is done by @brianteeman

avatar Bakual Bakual - open - 1 Mar 2017
avatar Bakual Bakual - change - 1 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Mar 2017
Category Administration Language & Strings
avatar Bakual Bakual - change - 1 Mar 2017
The description was changed
avatar Bakual Bakual - edited - 1 Mar 2017
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 2 Mar 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 2 Mar 2017

I have tested this item successfully on 0660141


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14297.

avatar infograf768
infograf768 - comment - 2 Mar 2017

Disagree. I explain:
The number of users depends on the parameters set in the module.

screen shot 2017-03-02 at 09 34 03

Therefore if you use the # per default (5) and there are 20 users logged, it is indeed the last 5 ones logged in and currently still logged in which are displayed.

If the confusion exists, then let's maybe rather use:
MOD_LOGGED_TITLE="Last Currently Logged-in Users"

avatar infograf768 infograf768 - test_item - 2 Mar 2017 - Tested unsuccessfully
avatar infograf768
infograf768 - comment - 2 Mar 2017

I have tested this item ? unsuccessfully on 0660141


For the reasons explained above.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14297.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 9 Mar 2017

Last Currently Logged-in Users ?

avatar Bakual
Bakual - comment - 31 Mar 2017

I'm closing this PR as @brianteeman is now able to create his own PRs again ?

avatar Bakual Bakual - change - 31 Mar 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-03-31 13:19:47
Closed_By Bakual
Labels Added: ? ?
avatar Bakual Bakual - close - 31 Mar 2017
avatar brianteeman
brianteeman - comment - 31 Mar 2017

Thanks @Bakual i am gong to abandon this. i really cant be bothered debating english with non english status

Add a Comment

Login with GitHub to post a comment