Joomla! Issue Tracker | Joomla! CMS #14294 - URL uppercase styleguide

?

Fixed in Code Base
1 Mar 2017
Medium
Build: staging
# 14294
Diff
brianteeman:URL-uppercase-styleguide

Pending

User tests: Successful: Unsuccessful:

Bakual
1 Mar 2017

Our styleguide says to use URL and not url or Url.

While this looks like a big PR, most of the changes are only in comments and doc blocks.
Only two actual language strings are affected:

COM_FINDER_INDEX_SEARCH_DESC
COM_USERS_FIELD_LOGIN_REDIRECT_CHOICE_DESC

Translators will only have to check if the existing translations already match their own styleguide.

Summary of Changes

Changing all instances to URL

Testing Instructions

Review

Disclaimer

Work is done by @brianteeman

c4db56a 28 Feb 2017

The styleguide says to use URL but we were using a mix of URL, url and Url - this standardises all the comments to use URL

7734ea3 28 Feb 2017

The styleguide says to use URL but we were using a mix of URL, url and Url - this standardises all the comments to use URL

b0b1da6 28 Feb 2017

The styleguide says to use URL but we were using a mix of URL, url and Url - this standardises all the comments to use URL

5172a18 28 Feb 2017

The styleguide says to use URL but we were using a mix of URL, url and Url - this standardises all the comments to use URL

0f537f3 28 Feb 2017

The styleguide says to use URL but we were using a mix of URL, url and Url - this standardises all the comments to use URL

1606bbd 28 Feb 2017

The styleguide says to use URL but we were using a mix of URL, url and Url - this standardises all the comments to use URL

3ee95e4 28 Feb 2017

The styleguide says to use URL but we were using a mix of URL, url and Url - this standardises all the comments to use URL

f01dee1 28 Feb 2017

The styleguide says to use URL but we were using a mix of URL, url and Url - this standardises all the comments to use URL

c54b3e6 28 Feb 2017

The styleguide says to use URL but we were using a mix of URL, url and Url - this standardises all the comments to use URL

29aa298 28 Feb 2017

The styleguide says to use URL but we were using a mix of URL, url and Url - this standardises all the comments to use URL

8138ed0 28 Feb 2017

The styleguide says to use URL but we were using a mix of URL, url and Url - this standardises all the comments to use URL

Bakual - open - 1 Mar 2017

Bakual - change - 1 Mar 2017

Status

New

⇒

Pending

joomla-cms-bot - change - 1 Mar 2017

Category

⇒

Administration com_banners com_cache com_categories com_checkin com_config com_contact com_content com_fields com_finder com_installer com_joomlaupdate com_languages com_login com_media com_menus com_messages com_modules com_newsfeeds com_plugins com_redirect

MATsxm - test_item - 1 Mar 2017 - Tested successfully

MATsxm - comment - 1 Mar 2017

I have tested this item ✅ successfully on 8138ed0

on review - thanks

(I like this one ? )

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14294.}

wilsonge - change - 1 Mar 2017

Status	Pending	⇒	Fixed in Code Base
Closed_Date	0000-00-00 00:00:00	⇒	2017-03-01 23:12:40
Closed_By		⇒	wilsonge
Labels	Added: ?

wilsonge - close - 1 Mar 2017

wilsonge - merge - 1 Mar 2017

Add a Comment

Login with GitHub to post a comment

Older
Newer