? ? ? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
25 Feb 2017

Pull Request for Issue c0eadd9

Summary of Changes

Just spaces to tabs + two additional inline comments

Testing Instructions

  • Just review
  • or install the patch and run the database fixer
    . confirm it still works.

Expected result

match the code standards

Actual result

does not match the code standards

Documentation Changes Required

None

avatar zero-24 zero-24 - open - 25 Feb 2017
avatar zero-24 zero-24 - change - 25 Feb 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Feb 2017
Category Administration com_admin
avatar zero-24 zero-24 - change - 25 Feb 2017
Labels Added: ? ?
avatar richard67 richard67 - test_item - 25 Feb 2017 - Tested successfully
avatar richard67
richard67 - comment - 25 Feb 2017

I have tested this item successfully on 270e8ca

Tested by code review. I can confirm it only changes code style and adds useful comments.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14247.

avatar richard67
richard67 - comment - 25 Feb 2017

P.S.: And of course I can also confrirm it matches code standards now.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14247.

avatar Sieger66 Sieger66 - test_item - 3 Mar 2017 - Tested successfully
avatar Sieger66
Sieger66 - comment - 3 Mar 2017

I have tested this item successfully on 270e8ca


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14247.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 3 Mar 2017

RTC as there are 2 successfully Tests?

avatar zero-24 zero-24 - change - 3 Mar 2017
Milestone Added:
Status Pending Ready to Commit
Labels Added: ?
avatar rdeutz rdeutz - change - 3 Mar 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-03-03 14:55:03
Closed_By rdeutz
Labels
avatar rdeutz rdeutz - close - 3 Mar 2017
avatar rdeutz rdeutz - merge - 3 Mar 2017

Add a Comment

Login with GitHub to post a comment