? ? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
24 Feb 2017

Pull Request for Issue # .

Summary of Changes

Use the Number form field https://docs.joomla.org/Number_form_field_type and not the text form field for storing numbers in the integer field

Testing Instructions

try to set up a integer form field before and after the patch

Expected result

you can just enter numbers

Actual result

you can enter everything.

Documentation Changes Required

None

avatar zero-24 zero-24 - open - 24 Feb 2017
avatar zero-24 zero-24 - change - 24 Feb 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Feb 2017
Category Front End Plugins
avatar RonakParmar
RonakParmar - comment - 25 Feb 2017

I have installed latest copy of joomla-cms in my local and tested "Number" form field, and before patch this field is working fine for me. It is allowing me to enter integer only.
Tested in Joomla! 3.7.0-rc1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14242.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 25 Feb 2017

I have tested this item ? unsuccessfully on 1702a59

With and -out got:
bildschirmfoto 2017-02-25 um 07 37 41
Click on Select an Option > no reaction.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14242.
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 25 Feb 2017 - Tested unsuccessfully
avatar RonakParmar
RonakParmar - comment - 25 Feb 2017

Before PR: I have changed text field of Article title to Number and tested, Number field is not allowing me to enter text. Attached screen dump for reference. Tested with Joomla! 3.7.0-rc1 — © 2017.
screen shot 2017-02-25 at 06 45 23


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14242.

avatar zero-24
zero-24 - comment - 25 Feb 2017

@franz-wohlkoenig what did you add as values to the settings?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 25 Feb 2017

@zero-24 Settings from Plugin:
bildschirmfoto 2017-02-25 um 09 25 22

avatar zero-24
zero-24 - comment - 25 Feb 2017

@franz-wohlkoenig this PR is just about the fields that you are not longer allowed to put in ther any chars.

The broken integer field is another issue :(

avatar zero-24
zero-24 - comment - 25 Feb 2017

@franz-wohlkoenig i have just tested it and it is working good here. Please try with the settings in the field itself and not with the settings from the plugin.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 25 Feb 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 25 Feb 2017

I have tested this item successfully on 1702a59

Tested with settings in the Field itself (not with Settings from Plugin).


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14242.

avatar zero-24
zero-24 - comment - 25 Feb 2017

@franz-wohlkoenig just to be sure can you save the current setting of the plugin and check if the dropdown is working than (even without a per field setting)? As it works good here. If not please open a new issue so we can keep tracke on that ?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 25 Feb 2017

@zero-24 works: first and second new Integer-Field shows Plugin-Setting as expected.

avatar zero-24
zero-24 - comment - 25 Feb 2017

Thanks for checking ?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 25 Feb 2017

as i don't know Reason why its now working (PR ist not apllied) i'm ...

avatar zero-24
zero-24 - comment - 25 Feb 2017

as i don't know Reason why its now working (PR ist not applied) i'm ...

The reason it don't work in the first place (without saving the plugin) was that the values are not saved to the database ?

avatar Sieger66 Sieger66 - test_item - 2 Mar 2017 - Tested successfully
avatar Sieger66
Sieger66 - comment - 2 Mar 2017

I have tested this item successfully on 1702a59

Name in Typ of Field: Integer(integer) it is not optimally.
We can enter integer and also we can enter numbers with comma for example: 3,1

But it is better as before the patch.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14242.

avatar jeckodevelopment jeckodevelopment - change - 2 Mar 2017
Status Pending Ready to Commit
avatar jeckodevelopment
jeckodevelopment - comment - 2 Mar 2017

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14242.

avatar rdeutz rdeutz - merge - 2 Mar 2017
avatar rdeutz rdeutz - change - 2 Mar 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-03-02 19:59:12
Closed_By rdeutz
Labels Added: ? ?
avatar rdeutz rdeutz - close - 2 Mar 2017

Add a Comment

Login with GitHub to post a comment