Feeling Lucky
?
[#14231] - Move JErrorPage to namespace
- Fixed in Code Base
- 27 Mar 2017
- Medium
- Build: 3.8-dev
- # 14231
- Diff
- Digital-Peak:j3/namespace/error
User tests: Successful: Unsuccessful:
Move JErrorPage class to namespace. Additionally some doc blocks are changed to be inline with rest.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
laoneo
- comment
- 24 Feb 2017
That's the reason why I do a pr per folder that we can do some cleanup during the move.
What about moving it to Joomla\Cms\Exception\ExceptionHandler? When we will have some more gloabal exceptions then we can put them all into that folder. Even JException.
mbabker
- comment
- 24 Feb 2017
I don't care if it's in a subnamespace, I just prefer the class name to not be ErrorPage
| Labels |
Added:
?
|
||
laoneo
- comment
- 24 Feb 2017
Done
| Category | Libraries | ⇒ | External Library Libraries Unit Tests |
| Labels |
Added:
?
?
|
||
| Category | Libraries External Library Unit Tests | ⇒ | Libraries |
| Labels |
Removed:
?
?
|
||
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-27 09:02:09 |
| Closed_By | ⇒ | wilsonge |
I know so far this has been just a straight "move to namespace" effort, but with this one class, can we take the opportunity to rename it to something more logical?
Joomla\Cms\ExceptionHandlerperhaps?It really isn't an error page renderer (even though that's what it is doing), it's the default global exception handler.