[#14223] - Sync sql install and samples files
- Fixed in Code Base
- 28 Feb 2017
- Medium
- Build: staging
- # 14223
- Diff
- csthomas:sync_sql_install_samples
User tests: Successful: Unsuccessful:
Pull Request for Issue #13981
Summary of Changes
- Mysql Samples: add helpful comments for graphic diff app to compare correct lines.
- Mysql Samples: I have removed IGNORE from INSERT clause and it still work.
- Postgrsql install: add comments, move down/up a few tables in order to sync with mysql install
- Postgrsql samples: add comments and sync with mysql samples
- Mssql: sync with postgresql install and samples, replace all [] quotes to "".
- Mssql: replace INSERT ... SELECT UNION ALL ... to insert with values INSERT ... VALUES (...), (...);
Why I did it: https://blog.sqlauthority.com/2008/07/02/sql-server-2008-insert-multiple-records-using-one-insert-statement-use-of-row-constructor/
Testing Instructions
Install each sample per database, install should success.
On postgresql and mssql please check front page and backend (specially Component lists).
Expected result
All as before, on postgresql and mssql after sync there may be more samples/items.
Actual result
Joomla with samles on postgresql and mssql does not work.
Take a look at backend->Components.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | SQL Installation Postgresql MS SQL Libraries |
Install joomla with each samples. DO NOT REMOVE INSTALL FOLDER.
Install joomla with "none - sample", test and at the end remove configuration.php file.
Then refresh page and install again next one, fields should be auto filled up, but password you have to retype.
Suggestion: always use the same prefix for tables and set to remove (not backup) tables on installation process.
@franz-wohlkoenig you need to use: https://github.com/csthomas/joomla-cms/archive/sync_sql_install_samples.zip as Using Joomla_3.7.0-rc1-dev-Full_Package? does not contain the changes here in that PR
I have tested this item
Test on MySQLi each Sample including "None".
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14223.
I started testing with mssql and the testing data using current staging. Here are my findings:
Testing Data - Frontend:
- Home: An error has occurred.
- Content Modules: [Microsoft][SQL Server Native Client 11.0][SQL Server]Incorrect syntax near ')'.
- Archiv: An error has occurred.
- Similar Tags: An error has occurred.
- Popular Tags: [Microsoft][SQL Server Native Client 11.0][SQL Server]Incorrect syntax near ')'.
- Compact tagged: should show one record
- Tagged items: should show one record
Trying to install multiple languages I get:
[Microsoft][SQL Server Native Client 11.0][SQL Server]Cannot insert the value NULL into column 'custom_data', table 'joomla37.dbo.#__extensions'; column does not allow nulls. INSERT fails.
Backend looks pretty good.
Thanks for details @waader.
Home: An error has occurred.
Unrelated query in mod_tags_similar. You mentioned that a few times before in other PRs. Fixed in #13262.
Content Modules: [Microsoft][SQL Server Native Client 11.0][SQL Server]Incorrect syntax near ')'.
Unrelated. query problem solved by #13262
Archive: An error has occurred.
I have found. Menu left.
This is query error also solved by #13262
Similar Tags: An error has occurred.
Popular Tags: [Microsoft][SQL Server Native Client 11.0][SQL Server]Incorrect syntax near ')'.
Unrelated. Query syntax problem fixed in #13262
Compact tagged: should show one record
Tagged items: should show one record
This is bug in query, not yet solved in #13262 :(
Trying to install multiple languages I get:
[Microsoft][SQL Server Native Client 11.0][SQL Server]Cannot insert the value NULL into column 'custom_data', table 'joomla37.dbo.#__extensions'; column does not allow nulls. INSERT fails.
This PR won't fix columns types or php code on mssql.
All mentioned errors are unrelated.
It would be good to have one test on postgresql.
When I try to install the Blog English (GB) Sample Data on mssql I get this message:
[Microsoft][SQL Server Native Client 11.0][SQL Server]The number of columns for each row in a table value constructor must be the same.
Installing the different data sets on postgresql went fine.
I confirm, I'm working on it.
| Labels |
Added:
?
?
|
||
| Category | SQL Installation Postgresql MS SQL Libraries | ⇒ | SQL Installation Postgresql MS SQL |
I have tested this item
Works for mssql and postgresql. Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14223.
RTC as there are 2 successfully Tests?
It would be good to test again on mysql and maybe on postgresql for make easier decision to approvers.
will test on mysqli
I have tested this item
all types of sample files can be installed.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14223.
I have tested this item
Works also with mysql.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14223.
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-28 13:05:35 |
| Closed_By | ⇒ | rdeutz | |
| Labels | |||
how is this be done in phpMyAdmin?