[#14214] - [3.7] Remove default and mark query as required for the SQL field
- Fixed in Code Base
- 24 Feb 2017
- Medium
- Build: staging
- # 14214
- Diff
- zero-24:sql_field
User tests: Successful: Unsuccessful:
Pull Request for Issue #14210
Summary of Changes
Remove default and mark query as required for the SQL field
Testing Instructions
- Set up a sql field with default values
- see the default is a dropdown of uses with id and name
- apply this patch
- notice that you now required to define a custom query else the result will be clear.
Expected result
you now required to define a custom query else the result will be clear.
Actual result
see the default is a dropdown of uses with id and name
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
I have tested this item
My first test I was able to save with no query - think that might have been a cached JS. But on second testing I was not able to save without sql query
HOWEVER if I put crap in the sql query I get a horrid raw mysql error message leaking parts of the query...
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14214.
Because in that other PR you were commenting on someone decided the error handling should be to just catch every possible Exception that gets thrown (major no-go, unless you're trying to have a "handle all the errors" error handler) and just uses the Exception message as the message that gets displayed (which with 3.7 if it's catching a JDatabaseExceptionExecuting object shouldn't exist on the message property anyway.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14214.
RTC as there are 2 successfully Tests?
I wait for response from phil and george ;)
Im happy with just the removing of the default sql that leaked information... additional validation (like searching for select, value and text can come later if needed.
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-24 11:29:59 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
|
||
I have tested this item? unsuccessfully on 436a897
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14214.