? ? Pending

User tests: Successful: Unsuccessful:

avatar eorisis
eorisis
22 Feb 2017

This PR adds a simple but important check, to make sure we do not display sensitive data publicly in production environments.

How to test

  1. Go to the Joomla Global Configuration and set Error Reporting to "None". Save.
  2. Take MySQL server down and make sure it stays down.
  3. Visit the Joomla site and notice the error.
  4. Apply this PR
  5. Refresh the Joomla site. You now only get "Error displaying the error page".

Pull Request for Issue #14115 .

Expected result

Blank page, nothing to show, similar to what would happen if there was a php error and Error Reporting option in Global Configuration was set to "None".

Actual result

  • Using the PDO driver we get the error:
    Error displaying the error page: Application Instantiation Error: Could not connect to PDO: SQLSTATE[HY000] [2002] Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2)
  • Using the MySQL or MySQLi drivers, we get the error:
    Error displaying the error page: Application Instantiation Error: Could not connect to MySQL.
avatar eorisis eorisis - open - 22 Feb 2017
avatar eorisis eorisis - change - 22 Feb 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Feb 2017
Category Libraries
avatar eorisis eorisis - change - 22 Feb 2017
The description was changed
avatar eorisis eorisis - edited - 22 Feb 2017
avatar tuts-22 tuts-22 - test_item - 22 Feb 2017 - Tested successfully
avatar tuts-22
tuts-22 - comment - 22 Feb 2017

I have tested this item successfully on be050be

The code works fine!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14177.

avatar eorisis eorisis - edited - 22 Feb 2017
avatar eorisis eorisis - change - 22 Feb 2017
The description was changed
avatar eorisis eorisis - edited - 22 Feb 2017
avatar eorisis eorisis - change - 22 Feb 2017
The description was changed
avatar eorisis eorisis - edited - 22 Feb 2017
avatar eorisis eorisis - change - 22 Feb 2017
The description was changed
avatar eorisis eorisis - edited - 22 Feb 2017
avatar marncz marncz - test_item - 23 Feb 2017 - Tested successfully
avatar marncz
marncz - comment - 23 Feb 2017

I have tested this item successfully on be050be

Works! Only getting: "Error displaying the error page" with error reporting set to None


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14177.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 24 Feb 2017

RTC as there are 2 successfully Tests?

avatar jeckodevelopment jeckodevelopment - change - 24 Feb 2017
Status Pending Ready to Commit
avatar jeckodevelopment
jeckodevelopment - comment - 24 Feb 2017

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14177.

avatar rdeutz rdeutz - change - 24 Feb 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-02-24 19:03:50
Closed_By rdeutz
Labels Added: ? ?
avatar rdeutz rdeutz - close - 24 Feb 2017
avatar rdeutz rdeutz - merge - 24 Feb 2017

Add a Comment

Login with GitHub to post a comment