[#14174] - [4.0] Move executable code out of index.php files
- Closed
- 26 Feb 2017
- Medium
- Build: staging
- # 14174
Similar to how we've already restructured the install app, the administrator/index.php and index.php files should be restructured in a way that allows those files to remain PHP 5.2 friendly while not impeding us using PHP 5.3+ features (like namespaced classes).
joomla-cms-bot
- | Labels |
Added:
?
|
||
The problem is if they are not PHP 5.2 friendly they can't be execued by PHP 5.2 so the check is not execued too.
Exactly. We still want to show a "your platform isn't supported" message to older PHP versions without the files being written in a way that makes them not parseable on older versions. So either everything in the index.php file has to remain in the global namespace or we give everyone who's on PHP 5.2 (or up to 5.5.8 depending on how the files are written and what language features are used) a PHP fatal because of the invalid syntax for those versions.
Basically, the index.php files should be simplified to this - https://github.com/joomla/joomla-cms/blob/4.0-dev/installation/index.php
jeckodevelopment
- | Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-26 11:23:47 |
| Closed_By | ⇒ | jeckodevelopment |
Why would we need those files to "remain PHP 5.2 friendly", given that the very first thing those files do is check for PHP 5.3+?