[#14172] - Improvements for JLibraryHelper
- Fixed in Code Base
- 24 Feb 2017
- Medium
- Build: staging
- # 14172
- Diff
- csthomas:library_helper
User tests: Successful: Unsuccessful:
Summary of Changes
Alternative solution for #14046
Instead load all libraries as it was done in previous PR this PR load only one and cache it alone.
Introduce a new method loadLibrary($element) and deprecate _load($element) method.
Testing Instructions
The same as in previous PR.
Documentation Changes Required
Document the deprecation.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
@joomdonation can you please write how you tested cause i don't understand #14046-instructions.
I have tested by interactive console #14046 (comment) which may be not available on a lots of php installs.
But you can open your template index.php file and paste:
print_r(JLibraryHelper::getLibrary('phpass', true));
print_r(JLibraryHelper::getLibrary('fof', true));
print_r(JLibraryHelper::getLibrary('phputf8', true));
// Repeat again to test data from cache
print_r(JLibraryHelper::getLibrary('phpass', true));
print_r(JLibraryHelper::getLibrary('fof', true));
print_r(JLibraryHelper::getLibrary('phputf8', true));
And test it with cache enabled and disabled. Result on page should be the same.
Optional with cache enabled you can open page a few times to check whether the cache is reused and does not recreated each time.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14172.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14172.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-24 19:02:46 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 2b91bb5
Tested with both cache on and off. Everything is working as expected.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14172.