?
avatar zero-24
zero-24
21 Feb 2017

Steps to reproduce the issue

  • Install beta2
  • see this screen:
    adminmenu2

Expected result

You can create admin menu entrys

Actual result

You can only see frontend entrys

Additional comments

It works if you using the following way:
adminmenu gif

avatar zero-24 zero-24 - open - 21 Feb 2017
avatar joomla-cms-bot joomla-cms-bot - change - 21 Feb 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 21 Feb 2017
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 21 Feb 2017

looks similar to comment

avatar astridx
astridx - comment - 21 Feb 2017

I can confirm this behavior.

avatar infograf768
infograf768 - comment - 21 Feb 2017

@izharaazmi

Please look at this.

avatar izharaazmi
izharaazmi - comment - 21 Feb 2017

Sure.

avatar infograf768
infograf768 - comment - 21 Feb 2017

btw, I do not get this behaviour using staging.
Screenshot coming

avatar infograf768
infograf768 - comment - 21 Feb 2017

adminmenu2

as you can see the Select Menu box is present before the Search Tools one.

avatar izharaazmi
izharaazmi - comment - 21 Feb 2017

image

On staging its ok. However, I likely know why it would happen. Some other PR that I do not remember right now, has moved all searchtools layout overrides centrally. However, not being comprehensive enough (it assumes we can only have one dropdown beside the search box) does not help com_menus.

Please make sure your installation has administrator/components/com_menus/layouts/joomla/searchtools/default.php and administrator/components/com_menus/layouts/joomla/searchtools/default/bar.php

Removing these would fallback to default layout and result in the said issue.

Hope this helps. I guess nothing to fix here. Do let me know if otherwise.

avatar izharaazmi
izharaazmi - comment - 21 Feb 2017

Ok. So the fix is simple now.

However this makes me wonder if we have something to prevent such mistakes
in future. Like what if a file that was marked for deletion in 3.0, and
later another file with same pathname is created in 3.8 that should not be
deleted. Are we ready to tackle this situation by any means?

avatar infograf768
infograf768 - comment - 21 Feb 2017

only by tests I'am afraid.
Do you make the PR or shall I?

avatar infograf768
infograf768 - comment - 21 Feb 2017

FYI, this error was done with 4e3a4aa#diff-e3c745afdbb43914c4f183a8c1587346

avatar izharaazmi
izharaazmi - comment - 21 Feb 2017

If you have the file open nearby and if you'd like to... then please. Or
let me know... its all the same :)

avatar infograf768
infograf768 - comment - 21 Feb 2017

Ok, doing it now

avatar izharaazmi
izharaazmi - comment - 21 Feb 2017

If I do any PR to tackle such situation, would that go in 3.7? If so I'd
hurry. Otherwise I'd do leisurely with 3.7.1 or 3.8 whatever fits.

avatar infograf768
infograf768 - comment - 21 Feb 2017

Let's first correct script.php
Then a PR dealing for such situations in the future is welcome, and if working I see no problem merging it asap.

avatar izharaazmi
izharaazmi - comment - 21 Feb 2017

Yes, thats perfectly fine. I'd look at this asap.

avatar infograf768
infograf768 - comment - 21 Feb 2017

Please test #14160

avatar joomla-cms-bot joomla-cms-bot - close - 21 Feb 2017
avatar infograf768 infograf768 - change - 21 Feb 2017
Status New Closed
Closed_Date 0000-00-00 00:00:00 2017-02-21 08:21:18
Closed_By infograf768
avatar joomla-cms-bot
joomla-cms-bot - comment - 21 Feb 2017
avatar infograf768
infograf768 - comment - 21 Feb 2017

Closing as we have a PR


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14159.

Add a Comment

Login with GitHub to post a comment