Labels |
Added:
?
|
I can confirm this behavior.
Please look at this.
Sure.
btw, I do not get this behaviour using staging.
Screenshot coming
On staging its ok. However, I likely know why it would happen. Some other PR that I do not remember right now, has moved all searchtools layout overrides centrally. However, not being comprehensive enough (it assumes we can only have one dropdown beside the search box) does not help com_menus.
Please make sure your installation has administrator/components/com_menus/layouts/joomla/searchtools/default.php
and administrator/components/com_menus/layouts/joomla/searchtools/default/bar.php
Removing these would fallback to default layout and result in the said issue.
Hope this helps. I guess nothing to fix here. Do let me know if otherwise.
Ok, found out
script.php deletes these files.
Ok. So the fix is simple now.
However this makes me wonder if we have something to prevent such mistakes
in future. Like what if a file that was marked for deletion in 3.0, and
later another file with same pathname is created in 3.8 that should not be
deleted. Are we ready to tackle this situation by any means?
only by tests I'am afraid.
Do you make the PR or shall I?
FYI, this error was done with 4e3a4aa#diff-e3c745afdbb43914c4f183a8c1587346
If you have the file open nearby and if you'd like to... then please. Or
let me know... its all the same :)
Ok, doing it now
If I do any PR to tackle such situation, would that go in 3.7? If so I'd
hurry. Otherwise I'd do leisurely with 3.7.1 or 3.8 whatever fits.
Let's first correct script.php
Then a PR dealing for such situations in the future is welcome, and if working I see no problem merging it asap.
Yes, thats perfectly fine. I'd look at this asap.
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-21 08:21:18 |
Closed_By | ⇒ | infograf768 |
Set to "closed" on behalf of @infograf768 by The JTracker Application at issues.joomla.org/joomla-cms/14159
Closing as we have a PR
looks similar to comment