Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#14149] - [4.0] Fix PHP Notice in authentication library

? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
20 Feb 2017

Pull Request for Issue #14147

Summary of Changes

This PR fixes the following error:

PHP Notice: Only variables should be passed by reference in ROOT/libraries/joomla/authentication/authentication.php on line 150

So rather than passing $this->getDispatcher() directly as a constructor argument, we make it a variable:

$dispatcher = $this->getDispatcher()

Testing Instructions

Not sure what they are as they were't provided in the issue.

avatar C-Lodder C-Lodder - open - 20 Feb 2017
avatar C-Lodder C-Lodder - change - 20 Feb 2017
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Feb 2017
Category ⇒ Libraries
avatar C-Lodder C-Lodder - change - 20 Feb 2017
The description was changed
avatar C-Lodder C-Lodder - edited - 20 Feb 2017
avatar joomdonation joomdonation - test_item - 20 Feb 2017 - Tested successfully
avatar joomdonation
joomdonation - comment - 20 Feb 2017

I have tested this item ✅ successfully on f5c3bd7

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14149.

avatar wilsonge wilsonge - change - 20 Feb 2017
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-02-20 12:10:54
Closed_By ⇒ wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 20 Feb 2017
avatar wilsonge wilsonge - merge - 20 Feb 2017

Add a Comment

Login with GitHub to post a comment