?
avatar infograf768
infograf768
20 Feb 2017

[20-Feb-2017 09:26:18 Europe/Paris] PHP Notice: Only variables should be passed by reference in ROOT/libraries/joomla/authentication/authentication.php on line 150

avatar infograf768 infograf768 - open - 20 Feb 2017
avatar joomla-cms-bot joomla-cms-bot - change - 20 Feb 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 20 Feb 2017
avatar C-Lodder
C-Lodder - comment - 20 Feb 2017

Am I right in assuming this:

if (class_exists($className))
{
	$plugin = new $className($this->getDispatcher(), (array) $plugin);
}

should be this:

if (class_exists($className))
{
$dispatcher = $this->getDispatcher();
$plugin = new $className($dispatcher, (array) $plugin);
}

??

avatar joomdonation
joomdonation - comment - 20 Feb 2017

@C-Lodder Your proposed fixed the issue. Please go ahead to make a PR for it. I think moving $dispatcher = $this->getDispatcher(); outside the foreach loop would be better

avatar C-Lodder
C-Lodder - comment - 20 Feb 2017
avatar wilsonge
wilsonge - comment - 20 Feb 2017

Closed as we have a PR

avatar wilsonge wilsonge - change - 20 Feb 2017
Status New Closed
Closed_Date 0000-00-00 00:00:00 2017-02-20 12:11:11
Closed_By wilsonge
avatar wilsonge wilsonge - close - 20 Feb 2017

Add a Comment

Login with GitHub to post a comment