[#14145] - Update Joomla Application packages to framework v2
- Fixed in Code Base
- 22 Feb 2017
- Medium
- Build: 4.0-dev
- # 14145
- Diff
- wilsonge:update-application
User tests: Successful: Unsuccessful:
Summary of Changes
Updates the Joomla Application package to version 2 of the framework.
Also phpmailer 6.0rc4 from rc3 as well as updating the dependencies of some of our test apps
Testing Instructions
Ensure the Joomla v4 branch has no additional breaks
Documentation Changes Required
Document the new version of packages included
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | External Library Libraries |
| Labels |
Added:
?
?
|
||
| Category | External Library Libraries | ⇒ | External Library Libraries Repository |
| Title |
|
||||||
You've got the session 1.0 package installed here too.
| Category | External Library Libraries Repository | ⇒ | External Library Libraries |
Removed session tests, added the DI as requested :)
| Category | External Library Libraries | ⇒ | External Library Libraries Unit Tests |
I have tested this item
Installed a copy of https://github.com/wilsonge/joomla-cms/tree/update-application with sample data. Created user account, articles, works
Tried to login from frontend, works. Tried to navigate through available menu items, found fatal error with some of them but it even happens before this PR.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14145.
| Labels |
Added:
?
|
||
I have removed tests for testAppendBody, testPrependBody, testSetBody and testClearHeaders, testGetHeaders, testSendHeaders and testSetHeader as these are no longer set in JApplicationWeb but instead at the framework level and therefore should be tested in the framework. I've fixed the tests for render in all 4 locations
I've just added a method that overrides the checkToken method in AbstractWebApplication and proxies to JSession::checkToken so we have one method that covers all our checks
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-22 02:46:28 |
| Closed_By | ⇒ | mbabker |
There are lots of instances in this PR that define an array using [] as opposed to array(). This is a PHP 5.4 feature and J3 still supports PHP 5.3.
This is a Joomla 4 PR ;)
Ahh, didn't see the branch, just looked at the title.
IMO we should go through the Framework repos first and start marking cross-version compatibility between the packages (most of them are either strictly 1.x or 2.x, not 1.x & 2.x where able). That way we can better test the inner dependencies then start working our way out.
But yes, this should be done soon.