Summary of Changes

Improve the cache use in BannersModelBanner::getItem() and remove a duplicated query.

1. Use the callback cache controller for reading from the cache instead of the base controller class.
2. Currently this method runs both $db->execute() and $db->loadObject() resulting in two queries, removes the $db->execute() call.
3. Handles cache exceptions and ignores other exceptions. Right now it's catching all thrown RuntimeException objects and calling JError::raiseError() which results in the error page being displayed. So there's really no point in trying to handle other errors here, let those bubble up the stack and hit the global handler which does the same if nothing else catches it (if a caller wanted to they could now have some sort of graceful fallback for other error conditions versus the model directly triggering the error page with no option of doing anything else; models are really a bad place to be calling JError at all).

Testing Instructions

A banner should still be read and used correctly when loaded through this model method.