[#14134] - Adjustments for JComponentHelper::load()
- Fixed in Code Base
- 21 Feb 2017
- Medium
- Build: staging
- # 14134
- Diff
- mbabker:component-helper-loader
User tests: Successful: Unsuccessful:
Summary of Changes
- Deprecate passing the
$optionparameter into the method and making sure the extension is actually loaded; this turns theload()method's single responsibility into loading the data into memory and nothing more. As of 4.0, the class internals (and if someone extended the class for any reason) should do its own validation the key exists in the static array versus relying on the loader to do it. - Changes the cache ID from the
$optionparameter to the result of__METHOD__to ensure a consistent cache ID for the loader versus something that is dynamic and probably results in extra calls to the cache due to the different IDs that result.
Testing Instructions
- Validate the query in the lambda function within
JComponentHelper::load()runs one time and one time only for the request. - Validate that there is only a single cache object for this data.
- Validate that everything still works normally otherwise.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I have tested this item
Test success.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14134.
zero-24
- | Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
?
|
||
I'm backing out on this for now.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-21 17:29:16 |
| Closed_By | ⇒ | mbabker | |
| Labels | |||
I have to back my comment at #14046 (comment).
For me this PR #14134 is still OK and should be reopened again.
Assets and Url router always load full components lists to memory.
So we can not load only one component to improve performance.
| Status | Closed | ⇒ | New |
| Closed_Date | 2017-02-21 17:29:16 | ⇒ | |
| Closed_By | mbabker | ⇒ | |
| Labels |
Removed:
?
|
||
| Status | New | ⇒ | Pending |
Alright, fine. I swear this is the last time I'm ever touching these helpers, my gray hair count is increasing exponentially dealing with them.
I'm sorry, I have created a mess.
There is no b/c problem. The method load($option) cache all components. Name of one component should not be a key for this cached data, so Michael use __METHOD__.
Please RTC.
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-21 20:24:52 |
| Closed_By | ⇒ | wilsonge |
I have tested this item✅ successfully on 65bb7f8
Tested and confirm all 3 points in testing instructions are passed.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14134.