[#14104] - Back to use require_once in JFormHelper
- Fixed in Code Base
- 16 Feb 2017
- Medium
- Build: staging
- # 14104
- Diff
- asika32764:patch-10
User tests: Successful: Unsuccessful:
Joomla3.7beta use JLoader instead directly require file in JFormHelper, but this will break all FormField file named list.php or same with existing core fields name.
For example, a field named JFormFieldFoo_List in /models/fields/foo/list.php will override the JFormFieldList class, so JFormHelper::loadFieldClass('list') will load JFormFieldFoo_List not JFormFieldList.
This will break many components.
Summary of Changes
Back to use require_once in JFormHelper
Testing Instructions
Create a field in models/fields/foo/list.php named JFormFieldFoo_List and include it in xml file, then try to load JFormHelper::loadFieldClass('list'); in other fields file, Joomla will not able to load JFormFieldList
Expected result
Should load JFormFieldList
Actual result
JFormFieldList class not definded.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
Just merge it. It's going to be easier to go backward on autoloading attempts than ever actually use it the way some of the APIs still work.
Merging then based on review since it's a simple revert.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-16 13:21:43 |
| Closed_By | ⇒ | Bakual | |
| Labels |
Added:
?
|
||
As reference, this has been changed to use JLoader with #12060
Pinging @mbabker as it was his PR that introduced this.