[#14099] - Add `input-medium` class in mod_search to get similar output as for mod_finder
- Fixed in Code Base
- 23 Feb 2017
- Medium
- Build: staging
- # 14099
- Diff
- sanderpotjer:patch-1
User tests: Successful: Unsuccessful:
Summary of Changes
Adding input-medium class for input field to get the same output as for mod_finder. We have had this issue for the joomla.org templates for example, where the output is different if using mod_search instead of mod_finder.
Testing Instructions
Before patch the input-medium class is not in the output for mod_search, after applying patch the output should be changed and input-medium is one of the classes.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
Do we have to worry about adding input-medium class will change the display of search module on existing websites?
This is fine. The input-medium width will only kick in, if the Box Width parameter for mod_search has no value.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14099.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14099.
unit test must be fixed before we can merge this @sanderpotjer ca you do that?
| Labels |
Added:
?
|
||
| Category | Modules Front End | ⇒ | Modules Front End Unit Tests |
I have fixed el unit test
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-23 00:12:47 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
|
||
I have tested this item✅ successfully on 10a5eb0
After Patch
com_search(Modules: Search) have ainput-mediumsimilar tocom_finder(Modules: Smart Search).This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14099.