Feeling Lucky
?
[#14079] - Workaround for missing SORT_NATURAL flag on php 5.3
- Fixed in Code Base
- 16 Feb 2017
- Medium
- Build: staging
- # 14079
- Diff
- csthomas:php53sort
User tests: Successful: Unsuccessful:
Pull Request for Issue #14063
Summary of Changes
Replace ksort($options, SORT_NATURAL); which does not work on php 5.3
to working equivalent uksort($options, 'strnatcmp');
Links:
- http://stackoverflow.com/questions/14096277/sorting-an-array-by-key-numerically
- http://stackoverflow.com/questions/12846030/keys-in-php-array-are-not-sorted-numerically
- http://stackoverflow.com/questions/15930583/array-keys-being-sorted-incorrectly-by-uksort-function
Testing Instructions
Core review or
create your own php test script to check uksort vs ksort or
real test on php 5.3 for component Multilingual Associations (take a look at #14063)
Expected result
No warning on php 5.3 and works for all other php versions.
Actual result
Warning on php 5.3
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_associations |
alikon
- comment
- 15 Feb 2017
I have tested this item
cannot test on php 5.3.x
tested on 5.5.x
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14079.
| Status | Pending | ⇒ | Ready to Commit |
infograf768
- comment
- 16 Feb 2017
RTC. Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14079.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-16 14:12:42 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 7af93ee
Confirm Notice in php 5.3.x is gone and that no problem shows using php >5.3.x
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14079.