[#14077] - Escape NULL byte in mssql driver
- Fixed in Code Base
- 22 Feb 2017
- Medium
- Build: staging
- # 14077
- Diff
- csthomas:escapenull
User tests: Successful: Unsuccessful:
Pull Request for Issue #13262 (comment)
Summary of Changes
MSSQL cut query string on NULL byte.
There not exists any escape sequence like \\\0 to escape NULL byte.
This PR use function CHAR(0) and concatenation to workaround it.
"... 'text\0suffix' ..." will be replace to
"... 'text' + CHAR(0) + 'suffix' ..."
Testing Instructions
Be sure that you have enabled plugin Smart Search - Categories.
Go to Smart Search component and click Index button:
before patch you should see error:
[Microsoft][ODBC Driver 13 for SQL Server][SQL Server]Unclosed quotation mark after the character string 'O:19:"FinderIndexerResult":19:{s:11:"'.
after patch you should see:
[Microsoft][ODBC Driver 13 for SQL Server][SQL Server]Cannot insert the value NULL into column 'term_id', table 'joomla.dbo.#__finder_tokens_aggregate'; column does not allow nulls. INSERT fails.
Expected result
Query is valid but database table row has wrong value (unrelated issue).
Actual result
Query is corrupted.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | MS SQL Libraries |
| Labels |
Added:
?
|
||
| Category | MS SQL Libraries | ⇒ | MS SQL Libraries Unit Tests |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14077.
zero-24
- | Title |
|
||||||
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
wilsonge
- | Title |
|
||||||
| Status | Ready to Commit | ⇒ | Fixed in Code Base | ||||
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-22 10:41:19 | ||||
| Closed_By | ⇒ | wilsonge | |||||
| Labels |
Added:
?
|
||||||
I have tested this item✅ successfully on 853ee0b
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14077.