? ? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
14 Feb 2017

Pull Request for Issue #13031 .

Summary of Changes

This a fix aimed towards the Joomla 4.x branch that ought to be in the 3.x branch too. Currently we don't always set this value (but with STRICT_TRANS_TABLES disabled it automatically has a null date applied). In the 4.x branch we've enabled this parameter causing modules to fail to save.

We are doing this same check in com_contact for example hence why I'm making this PR at the staging branch rather than 4.x even if the results aren't obvious to test in this branch

Testing Instructions

Check modules continue to save in the 3.x branch with a null date if any of publish up, publish down or the checked out time isn't set

Documentation Changes Required

None

avatar wilsonge wilsonge - open - 14 Feb 2017
avatar wilsonge wilsonge - change - 14 Feb 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Feb 2017
Category Libraries
avatar wilsonge wilsonge - change - 14 Feb 2017
Labels Added: ?
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 15 Feb 2017

Null Data works in Publish up, publish down on several Modules,
in Modules: Articles - Category works on Start Date Range and To Date too

@wilsonge Can't find Field checkout out time.

avatar wilsonge
wilsonge - comment - 15 Feb 2017

I've removed checked out time. It corresponds to whether the module is checked out or not - but I think we are actually ok there, because JTable and JModel seem to handle it correctly

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 15 Feb 2017

I have tested this item successfully on 11c0072


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14073.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 15 Feb 2017 - Tested successfully
avatar csthomas
csthomas - comment - 16 Feb 2017

I have tested this item successfully on 11c0072


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14073.

avatar csthomas csthomas - test_item - 16 Feb 2017 - Tested successfully
avatar zero-24 zero-24 - change - 16 Feb 2017
Milestone Added:
Status Pending Ready to Commit
Labels Added: ?
avatar rdeutz rdeutz - change - 16 Feb 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-02-16 19:20:18
Closed_By rdeutz
Labels
avatar rdeutz rdeutz - close - 16 Feb 2017
avatar rdeutz rdeutz - merge - 16 Feb 2017

Add a Comment

Login with GitHub to post a comment