[#14070] - Field offline. Remove class btn-group-reversed
- Closed
- 22 Feb 2017
- Medium
- Build: staging
- # 14070
- Diff
- bertmert:patch-6
User tests: Successful: Unsuccessful:
Pull Request for Issue #14068
Please see comments #14068 (comment) and #14068 (comment)
Summary of Changes
- Global configuration. Removed class
btn-group-reversedfrom field offline because of wrong(?) button coloring.
Testing Instructions
-
Install current staging.
-
Go to global configuration.
-
Test coloring of button
Site Offline.Yesis red.Nois green. -
Apply patch
-
Test again.
-
Yesshould be green andNoshould be red now.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_config |
That is by design. The idea is that the recommended setting is green (No = Site not offline).
Hmmm. When I compare several settings here and there then this seems a lonely spot where Green == Recommended.
Use URL Rewriting: Recommended?
Shared Sessions: Recommended?
Platform Specific Caching: ...
Enable FTP:
Enable Proxy:
From my point of view that's not consistent.
If you read the PR, he said himself that this is only one parameter and more should be done as well.
I think we should leave it as how it is. Yes should be Red in this case to warn admin if he puts the site offline.
we don't change this at this point, we need a more solid concept for what is right or wrong. Seems to me a task for the UX team
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-22 16:56:42 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 78496ec
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14070.