? ? Pending

User tests: Successful: Unsuccessful:

avatar rdeutz
rdeutz
14 Feb 2017

Summary of Changes

Move the PHPCS tests to drone. This gives us more resources on travis and drone is much faster with the result of the code style check

Documentation Changes Required

People need to understand that our code style is now tested with drone and not with travis, biggest change here is that we don't say (in 9 fro 10 failures) "Make Travis happy" any time longer it will be "Make Drone happy" :-)

80b4cda 14 Feb 2017 avatar rdeutz typo
avatar rdeutz rdeutz - open - 14 Feb 2017
avatar rdeutz rdeutz - change - 14 Feb 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Feb 2017
Category Unit Tests
avatar wilsonge wilsonge - change - 14 Feb 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-02-14 16:57:30
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge wilsonge - close - 14 Feb 2017
avatar wilsonge wilsonge - merge - 14 Feb 2017
avatar wilsonge
wilsonge - comment - 14 Feb 2017

Sounds like a plan to me :)

avatar photodude
photodude - comment - 14 Feb 2017

"Make Travis happy" or "Make Drone happy" commits drive me nuts.... every one of those should be "comply with project code standards"

Maybe once we can move the PHPCS2 branch to the main and we have some autofixers available we can see more "apply project code standard" commits.

Add a Comment

Login with GitHub to post a comment