Feeling Lucky
?
[#14061] - [bug] Fix localPath in gallery plugin. Closes #14056
- Fixed in Code Base
- 14 Feb 2017
- Medium
- Build: staging
- # 14061
- Diff
- marrouchi:patch-1
User tests: Successful: Unsuccessful:
Pull Request for Issue #14056.
Summary of Changes
Replace '/' by DIRECTORY_SEPARATOR for wamp support.
Testing Instructions
!! Testing must be made on Windows Systems
1.Create article.
2.Create custom field type gallery
3.On article gallery field select one folder to show the images, for example sampledata
4.Open article on frontend
Expected result
Article with photo gallery
Actual result
Warning message without gallery
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-14 13:18:02 |
| Closed_By | ⇒ | wilsonge |
wilsonge
- comment
- 14 Feb 2017
Merged on review
I think using JPath::clean should be preferred instead of using DIRECTORY_SEPARATOR. I had a PR open until two weeks ago when I was told the issue was resolved. See https://github.com/joomla/joomla-cms/pull/13726/files