Feeling Lucky
?
[#14057] - Fix issue with callback cache controller hashing Closures
- Fixed in Code Base
- 14 Feb 2017
- Medium
- Build: staging
- # 14057
- Diff
- mbabker:cache-closure-fix
User tests: Successful: Unsuccessful:
Summary of Changes
When using a Closure with the cache's callback controller, generating the ID will fail because it attempts to serialize a Closure which isn't allowed. Change the code to use an object hash for the Closure instead.
Testing Instructions
Probably should be easily triggered just by turning on caching for core because there are a few places where Closures are used now. Failing that, I guess something like this should work as a test case:
JFactory::getCache('_system', 'callback')->get(function () { echo 'Hello World!'; });Expected result
Page displays correctly
Actual result
Page errors out due to attempted serialization of a Closure
Documentation Changes Required
N/A
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-14 15:45:15 |
| Closed_By | ⇒ | wilsonge |
Merging on code review and the test by @waader in #13262